Skip to content

change babel-plugin-react-compiler to be a dev dependency #80733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: canary
Choose a base branch
from

Conversation

lewxdev
Copy link

@lewxdev lewxdev commented Jun 20, 2025

should be a dev dependency since babel-plugin-react-compiler is a build-time tool

should be a dev dependency since babel-plugin-react-compiler is a build-time tool
@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Jun 20, 2025
@ijjk
Copy link
Member

ijjk commented Jun 20, 2025

Allow CI Workflow Run

  • approve CI run for commit: 5b5bec9

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Jun 20, 2025

Allow CI Workflow Run

  • approve CI run for commit: 7a5d430

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@icyJoseph
Copy link
Contributor

Hi,

Not to start a controversy here, but, for the use cases we have, this is more of a convention to keep order, and not necessarily, though some details, something that has to be. Although, now in 2025, I feel like, the deps and devDeps separation is still going stronger, and stronger than ever. I've sat through discussions, threads, etc, where all sides have made very valid claims.

And this had some back and forth in create-next-app as well:

And even in some React docs, they use this plugin as a devDep, and other just dep:

@@ -17,7 +17,7 @@ This avoids compiling everything and keeps the performance cost minimal. You may
To use it, install the `babel-plugin-react-compiler`:

```bash filename="Terminal"
npm install babel-plugin-react-compiler
npm install -D babel-plugin-react-compiler
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the RC version is out, would you mind updating it to:

Suggested change
npm install -D babel-plugin-react-compiler
npm install --save-dev --save-exact babel-plugin-react-compiler@rc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Related to Next.js' official documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants