fix(ssr)!: don't access `Object` variable in ssr transformed code #19996

hi-ogawa · 2025-05-03T06:19:42Z

Description

I added __vite_ssr_exportName__ to runtime context so we can move out Object.definedProperty from ssr transformed code. ~~Since this breaks vite-node, I added a patch to add the same runtime context.~~ (EDIT: updated to vitest 3.2 beta)

This is likely hard to test on ecosystem ci since anyone using Vitest / vite-node breaks 🤔
I made a Vitest side PR (and package) so they can be tested if both overrides are setup vitest-dev/vitest#7925.

As seen in ecosystem-ci below, this change didn't break vite-plugin-cloudflare nor vite-environment-examples because their custom module runner uses Object.keys(context) and Object.values(context) without referencing exact context keys https://github.com/cloudflare/workers-sdk/blob/1cd30a554f00dfd7bff43bbd3e601bc67f7acb2b/packages/vite-plugin-cloudflare/src/runner-worker/module-runner.ts#L55-L69

hi-ogawa · 2025-05-03T06:24:08Z

/ecosystem-ci run

pkg-pr-new · 2025-05-03T06:25:10Z

Open in StackBlitz

npm i https://pkg.pr.new/vite@19996

commit: da582f8

vite-ecosystem-ci · 2025-05-03T06:56:04Z

📝 Ran ecosystem CI on 9ac01e3: Open

suite	result	latest scheduled
analogjs	❌ failure	✅ success
ladle	❌ failure	✅ success
nuxt	❌ failure	✅ success
laravel	❌ failure	❌ failure
quasar	❌ failure	✅ success
histoire	❌ failure	✅ success
storybook	❌ failure	✅ success
react-router	⏹️ cancelled	✅ success
sveltekit	❌ failure	✅ success
vike	❌ failure	❌ failure
unocss	❌ failure	✅ success
vite-plugin-svelte	❌ failure	✅ success
vite-plugin-react	❌ failure	✅ success
vite-plugin-vue	❌ failure	✅ success
vitepress	❌ failure	✅ success
waku	❌ failure	✅ success
vitest	❌ failure	❌ failure
vuepress	❌ failure	✅ success

✅ astro, rakkas, previewjs, qwik, marko, vite-plugin-pwa, vite-plugin-react-swc, vite-environment-examples, vite-plugin-cloudflare, vite-setup-catalogue

sapphi-red

LGTM 👍

vite-ecosystem-ci · 2025-06-03T03:50:46Z

📝 Ran ecosystem CI on 2a7473c: Open

suite	result	latest scheduled
nuxt	✅ success	❌ failure
react-router	⏹️ cancelled	✅ success
astro	❌ failure	❌ failure
analogjs	❌ failure	❌ failure
histoire	❌ failure	❌ failure
waku	❌ failure	✅ success
vitest	❌ failure	✅ success
vite-plugin-cloudflare	❌ failure	❌ failure
previewjs	❌ failure	❌ failure
vike	❌ failure	❌ failure

✅ quasar, ladle, storybook, marko, qwik, vite-environment-examples, rakkas, vitepress, unocss, vite-plugin-react, vuepress, vite-plugin-vue, vite-setup-catalogue, vite-plugin-pwa, vite-plugin-svelte, sveltekit, laravel

sapphi-red · 2025-06-03T04:00:52Z

I tried adding overrides (vitejs/vite-ecosystem-ci#387) but it seems it doesn't work for some and would make it difficult to understand the failures, so probably better to keep it as-is.

sapphi-red · 2025-06-06T06:32:35Z

/ecosystem-ci run

vite-ecosystem-ci · 2025-06-06T07:03:31Z

📝 Ran ecosystem CI on da582f8: Open

suite	result	latest scheduled
ladle	❌ failure	✅ success
astro	❌ failure	❌ failure
analogjs	❌ failure	❌ failure
histoire	❌ failure	❌ failure
react-router	⏹️ cancelled	✅ success
quasar	❌ failure	✅ success
previewjs	❌ failure	❌ failure
laravel	❌ failure	✅ success
unocss	❌ failure	✅ success
vike	❌ failure	❌ failure
vite-plugin-cloudflare	❌ failure	❌ failure
waku	❌ failure	✅ success
vite-plugin-react	❌ failure	✅ success
vuepress	❌ failure	✅ success
vitepress	❌ failure	✅ success
sveltekit	❌ failure	❌ failure

✅ marko, storybook, rakkas, qwik, nuxt, vite-plugin-pwa, vite-environment-examples, vite-plugin-vue, vite-setup-catalogue, vite-plugin-svelte, vitest

hi-ogawa · 2025-06-06T07:19:06Z

Should I try to send PRs on ecosystem repos (at least the ones passing on the main)? Not sure how long renovate will get Vitest bumped.

I sent a message on discord in case it helps.

sapphi-red · 2025-06-06T08:51:17Z

Thanks for sending the message 🙏 I hope some of the failures will be resolved next week, assuming the renovate will run once a week.

sapphi-red · 2025-06-06T08:54:47Z

Ah, maybe adding "vitest@~3.0.0||~3.1.0>vite": "^6.3.5" to overrides might work

hi-ogawa · 2025-06-06T09:39:47Z

Aha, that sounds great. Some frameworks like react-router uses vite-node, so that also needs override if you want to check.

I also noticed there's very old Vitest in the ecosystem "vitest": "^0.34.4" https://github.com/laravel/vite-plugin/blob/4a1c05598cc9fd14a26ceb9a125fee17fb828002/package.json#L53, which won't match vitest@~3.0.0||~3.1.0.

sapphi-red · 2025-06-06T10:04:21Z

I've tested it at vitejs/vite-ecosystem-ci#389
It seems to work for most suites. But it didn't work with react-router.

hi-ogawa · 2025-06-06T10:32:16Z

Just in case, I tested react router and overrides seems to be fine locally with:

    "overrides": {
      "vite": "https://pkg.pr.new/vite@da582f8",
      "vite-node": "3.2.2",

sapphi-red · 2025-06-09T04:33:30Z

/ecosystem-ci run

vite-ecosystem-ci · 2025-06-09T04:57:37Z

📝 Ran ecosystem CI on da582f8: Open

suite	result	latest scheduled
analogjs	❌ failure	❌ failure
histoire	❌ failure	❌ failure
astro	❌ failure	❌ failure
react-router	❌ failure	✅ success
vike	❌ failure	❌ failure
sveltekit	❌ failure	❌ failure
vite-plugin-cloudflare	❌ failure	❌ failure

✅ ladle, laravel, marko, nuxt, quasar, qwik, storybook, vite-plugin-vue, vite-environment-examples, unocss, vite-plugin-svelte, vitest, rakkas, vite-plugin-react, waku, vuepress, vite-setup-catalogue, vite-plugin-pwa, vitepress

sapphi-red · 2025-06-09T05:24:46Z

Let's now merge this PR as the ecosystem-ci is mostly passing.

hi-ogawa added 2 commits May 3, 2025 15:13

fix(ssr)!: don't access Object variable in module scope

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

8478068

test: add test

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

Loading
Loading status checks…

9ac01e3

vite-ecosystem-ci bot added the trigger: preview label May 3, 2025

hi-ogawa mentioned this pull request May 3, 2025

fix(vite-node): add __vite_ssr_exportName__ vitest-dev/vitest#7925

Merged

6 tasks

hi-ogawa marked this pull request as ready for review May 3, 2025 08:47

hi-ogawa mentioned this pull request May 3, 2025

fix(ssr): use globalThis.Object in ssr transform code #19997

Closed

sapphi-red added this to the 7.0 milestone May 7, 2025

sapphi-red added p3-minor-bug feat: ssr breaking change labels May 7, 2025

sapphi-red reviewed May 7, 2025

View reviewed changes

sapphi-red previously approved these changes May 7, 2025

View reviewed changes

Merge branch 'main' into fix-ssr-object-var

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

Loading
Loading status checks…

8dd16df

hi-ogawa dismissed sapphi-red’s stale review via 8dd16df May 23, 2025 09:07

hi-ogawa mentioned this pull request May 23, 2025

SSR transformed named imported functions don't work with debuggers "step-into" #18325

Open

7 tasks

hi-ogawa added 5 commits May 29, 2025 09:21

Merge branch 'main' into fix-ssr-object-var

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

d8542ed

chore: use vitest beta

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

Loading
Loading status checks…

92cc912

Merge branch 'main' into fix-ssr-object-var

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

b6b6ec6

chore(deps): vitest 3.2

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

Loading
Loading status checks…

7125e06

chore: ^3.2.0

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

Loading
Loading status checks…

2a7473c

This comment was marked as resolved.

Sign in to view

sapphi-red mentioned this pull request Jun 3, 2025

chore: override vitest vitejs/vite-ecosystem-ci#387

Closed

This comment was marked as outdated.

Sign in to view

chore: merge main

Verified

This commit was signed with the committer’s verified signature.

sapphi-red 翠

GPG key ID: B5533BC1E6C4ED51

Verified
Learn about vigilant mode

Loading
Loading status checks…

da582f8

sapphi-red mentioned this pull request Jun 9, 2025

feat: use Vite 6 for old Vitest vitejs/vite-ecosystem-ci#389

Merged

This comment was marked as outdated.

Sign in to view

This was referenced Jun 9, 2025

chore: set vite-node overrides for waku and react-router vitejs/vite-ecosystem-ci#393

Merged

feat(dev): update vite-node for Vite 7 support remix-run/react-router#13781

Open

sapphi-red approved these changes Jun 9, 2025

View reviewed changes

sapphi-red merged commit fceff60 into vitejs:main Jun 9, 2025
16 checks passed

sapphi-red added a commit to sapphi-red/vite that referenced this pull request Jun 9, 2025

docs: add vitejs#19996

Verified

This commit was signed with the committer’s verified signature.

sapphi-red 翠

GPG key ID: B5533BC1E6C4ED51

Verified
Learn about vigilant mode

febb4a4

hi-ogawa deleted the fix-ssr-object-var branch June 9, 2025 05:43

sheremet-va mentioned this pull request Jun 11, 2025

import a variable with the name "Object" will result in an unexpected error vitest-dev/vitest#4829

Closed

6 tasks

fix(ssr)!: don't access Object variable in ssr transformed code #19996

fix(ssr)!: don't access Object variable in ssr transformed code #19996

Conversation

hi-ogawa commented May 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

Uh oh!

hi-ogawa commented May 3, 2025

Uh oh!

pkg-pr-new bot commented May 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vite-ecosystem-ci bot commented May 3, 2025

Uh oh!

sapphi-red left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as outdated.

This comment was marked as outdated.

vite-ecosystem-ci bot commented Jun 3, 2025

Uh oh!

sapphi-red commented Jun 3, 2025

Uh oh!

Uh oh!

sapphi-red commented Jun 6, 2025

Uh oh!

vite-ecosystem-ci bot commented Jun 6, 2025

Uh oh!

hi-ogawa commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sapphi-red commented Jun 6, 2025

Uh oh!

sapphi-red commented Jun 6, 2025

Uh oh!

hi-ogawa commented Jun 6, 2025

Uh oh!

sapphi-red commented Jun 6, 2025

Uh oh!

hi-ogawa commented Jun 6, 2025

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

sapphi-red commented Jun 9, 2025

Uh oh!

vite-ecosystem-ci bot commented Jun 9, 2025

Uh oh!

sapphi-red commented Jun 9, 2025

Uh oh!

Uh oh!

fix(ssr)!: don't access `Object` variable in ssr transformed code #19996

fix(ssr)!: don't access `Object` variable in ssr transformed code #19996

hi-ogawa commented May 3, 2025 •

edited

Loading

pkg-pr-new bot commented May 3, 2025 •

edited

Loading

hi-ogawa commented Jun 6, 2025 •

edited

Loading