Skip to content

Issue 1: Incorrect comparison with MAIN_CUDA_VERSION for CPU target #19882

@PrinceSajjadHussain

Description

@PrinceSajjadHussain
The `get_vllm_version` function compares device-specific versions (CUDA, ROCm, etc.) against `MAIN_CUDA_VERSION` regardless of the target device. This comparison is irrelevant and potentially misleading when the target device is CPU, as it could lead to the inclusion of `sep` (e.g., "+") in the version string even when no CUDA-related components are involved. The condition `gaudi_sw_version != MAIN_CUDA_VERSION` should only be evaluated for specific devices, not for general cases.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions