Skip to content

[Benchmark] Fix Value of type "SampleRequest" is not indexable #18032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

b8zhong
Copy link
Contributor

@b8zhong b8zhong commented May 12, 2025

Mypy type error here. Value of type "SampleRequest" is not indexable

So this fixes it.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link

mergify bot commented May 13, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @b8zhong.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label May 13, 2025
Copy link
Member

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Please do rebase so we can put on auto merge.

@b8zhong b8zhong force-pushed the fix/benchmark branch 2 times, most recently from 68c47c6 to e088674 Compare May 13, 2025 15:38
@mergify mergify bot added documentation Improvements or additions to documentation and removed needs-rebase labels May 13, 2025
@b8zhong
Copy link
Contributor Author

b8zhong commented May 13, 2025

Done 👍

@b8zhong
Copy link
Contributor Author

b8zhong commented May 13, 2025

I don't think the CI failure is related 👍

@b8zhong
Copy link
Contributor Author

b8zhong commented May 18, 2025

@ywang96 Is okay I think

Signed-off-by: Brayden Zhong <b8zhong@uwaterloo.ca>
@b8zhong
Copy link
Contributor Author

b8zhong commented Jun 18, 2025

diff --git a/vllm/model_executor/models/qwen2_vl.py b/vllm/model_executor/models/qwen2_vl.py
index 3b939a4..690b8e0 100644
--- a/vllm/model_executor/models/qwen2_vl.py
+++ b/vllm/model_executor/models/qwen2_vl.py
@@ -759,11 +759,11 @@ class Qwen2VLProcessingInfo(BaseProcessingInfo):
     ) -> Qwen2VLProcessor:
         return self.ctx.get_hf_processor(
             Qwen2VLProcessor,
-            image_processor=self.get_image_processor(
-                min_pixels=min_pixels,
-                max_pixels=max_pixels,
-                size=size,
-                use_fast=kwargs.get("use_fast", True)),
+            image_processor=self.get_image_processor(min_pixels=min_pixels,
+                                                     max_pixels=max_pixels,
+                                                     size=size,
+                                                     use_fast=kwargs.get(
+                                                         "use_fast", True)),
             **kwargs,
         )

I think pre-commit is broken on main?

@ywang96 ywang96 added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 19, 2025
@vllm-bot vllm-bot merged commit 5aa4a01 into vllm-project:main Jun 20, 2025
74 of 75 checks passed
@b8zhong b8zhong deleted the fix/benchmark branch June 20, 2025 13:20
yeqcharlotte pushed a commit to yeqcharlotte/vllm that referenced this pull request Jun 22, 2025
juncheoll pushed a commit to juncheoll/vllm that referenced this pull request Jun 23, 2025
…m-project#18032)

Signed-off-by: Brayden Zhong <b8zhong@uwaterloo.ca>
Signed-off-by: juncheoll <th6re8e@naver.com>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
…m-project#18032)

Signed-off-by: Brayden Zhong <b8zhong@uwaterloo.ca>
Signed-off-by: minpeter <kali2005611@gmail.com>
fhl2000 pushed a commit to fhl2000/vllm that referenced this pull request Jun 25, 2025
…m-project#18032)

Signed-off-by: Brayden Zhong <b8zhong@uwaterloo.ca>
Signed-off-by: fhl <2410591650@qq.com>
gmarinho2 pushed a commit to gmarinho2/vllm that referenced this pull request Jun 26, 2025
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jun 30, 2025
wseaton pushed a commit to wseaton/vllm that referenced this pull request Jun 30, 2025
…m-project#18032)

Signed-off-by: Brayden Zhong <b8zhong@uwaterloo.ca>
Signed-off-by: Will Eaton <weaton@redhat.com>
wseaton pushed a commit to wseaton/vllm that referenced this pull request Jun 30, 2025
wwl2755-google pushed a commit to wwl2755-google/vllm that referenced this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants