-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
[Benchmark] Fix Value of type "SampleRequest" is not indexable
#18032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
This pull request has merge conflicts that must be resolved before it can be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! Please do rebase so we can put on auto merge.
68c47c6
to
e088674
Compare
Done 👍 |
I don't think the CI failure is related 👍 |
@ywang96 Is okay I think |
I think pre-commit is broken on main? |
…m-project#18032) Signed-off-by: Brayden Zhong <b8zhong@uwaterloo.ca>
…m-project#18032) Signed-off-by: Brayden Zhong <b8zhong@uwaterloo.ca> Signed-off-by: juncheoll <th6re8e@naver.com>
…m-project#18032) Signed-off-by: Brayden Zhong <b8zhong@uwaterloo.ca> Signed-off-by: minpeter <kali2005611@gmail.com>
…m-project#18032) Signed-off-by: Brayden Zhong <b8zhong@uwaterloo.ca> Signed-off-by: fhl <2410591650@qq.com>
…m-project#18032) Signed-off-by: Brayden Zhong <b8zhong@uwaterloo.ca>
…m-project#18032) Signed-off-by: Brayden Zhong <b8zhong@uwaterloo.ca>
…m-project#18032) Signed-off-by: Brayden Zhong <b8zhong@uwaterloo.ca> Signed-off-by: Will Eaton <weaton@redhat.com>
…m-project#18032) Signed-off-by: Brayden Zhong <b8zhong@uwaterloo.ca>
…m-project#18032) Signed-off-by: Brayden Zhong <b8zhong@uwaterloo.ca>
Mypy type error here.
Value of type "SampleRequest" is not indexable
So this fixes it.