[Misc] update cuda version #19526
[Misc] update cuda version #19526
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @reidliu41, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request makes a minor update to the documentation within one of the example files. It specifically adjusts the stated CUDA version requirement for the LMCache CPU offload example to reflect a newer minimum version.
Highlights
- Documentation Update: Updated the required CUDA version specified in the docstring for the LMCache CPU offload example.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the documented CUDA version requirement in the cpu_offload_lmcache.py example script. The change updates the requirement from CUDA 12.1 to 12.4+. The change itself is minimal and correctly updates the comment string. It's important to ensure this documented requirement accurately reflects the actual minimum CUDA version needed for this example to function correctly.
| @@ -17,7 +17,7 @@ | |||
| (Without enable_chunked_prefill) | |||
|
|
|||
| Note that `lmcache` is needed to run this example. | |||
| Requirements: Linux, Python: 3.10 or higher, CUDA: 12.1 | |||
| Requirements: Linux, Python: 3.10 or higher, CUDA: 12.4+ | |||
There was a problem hiding this comment.
This change updates the documented minimum CUDA version required to run this specific example. Please ensure that CUDA: 12.4+ accurately reflects the lowest CUDA version compatible with the dependencies and features used in this example.
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
|
@DarkLight1337 maybe I remove it, seems they updated again, just refer to the doc |
|
Can you update our docs to point to their requirements? |
Signed-off-by: reidliu41 <reid201711@gmail.com>
reidliu41
force-pushed
the
update-cuda-version
branch
from
2f7e5e3 to
c480a9a
Compare
github-actions
bot
added
the
ready
Signed-off-by: reidliu41 <reid201711@gmail.com> Co-authored-by: reidliu41 <reid201711@gmail.com>
Signed-off-by: reidliu41 <reid201711@gmail.com> Co-authored-by: reidliu41 <reid201711@gmail.com> Signed-off-by: juncheoll <th6re8e@naver.com>
Signed-off-by: reidliu41 <reid201711@gmail.com> Co-authored-by: reidliu41 <reid201711@gmail.com> Signed-off-by: fhl <2410591650@qq.com>
Signed-off-by: reidliu41 <reid201711@gmail.com> Co-authored-by: reidliu41 <reid201711@gmail.com>
Signed-off-by: reidliu41 <reid201711@gmail.com> Co-authored-by: reidliu41 <reid201711@gmail.com>
Signed-off-by: reidliu41 <reid201711@gmail.com> Co-authored-by: reidliu41 <reid201711@gmail.com> Signed-off-by: Will Eaton <weaton@redhat.com>
Signed-off-by: reidliu41 <reid201711@gmail.com> Co-authored-by: reidliu41 <reid201711@gmail.com>
Signed-off-by: reidliu41 <reid201711@gmail.com> Co-authored-by: reidliu41 <reid201711@gmail.com>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
https://docs.lmcache.ai/getting_started/installation.html
Test Plan
Test Result
(Optional) Documentation Update