[BugFix] Don't catch BaseException when dumping execute_model errors

[njhill]

dump_engine_exception() is intended to dump pertinent state for diagnostic purposes when model_executor.execute_model() raises an error.

We should be catching Exception rather than BaseException here because a non-Exception implies failure due to some external signal such as SystemExit or KeyboardInterrupt.

Catching SystemExit here has lead to more confusing behaviour when diagnosing problems.

[github-actions]

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

[gemini-code-assist]

Summary of Changes

Hello @njhill, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the error handling for the execute_model function to ensure that diagnostic information is only dumped when an actual execution error occurs, rather than when the process receives a system signal. By changing the caught exception type from BaseException to Exception, we avoid triggering the dump for non-error interruptions like SystemExit, making debugging clearer.

Highlights

• Exception Handling Scope: I've narrowed the scope of exceptions caught around the execute_model call and within the dump_engine_exception utility from BaseException to Exception.
• Bug Fix: This change fixes a bug where system signals like SystemExit or KeyboardInterrupt were being caught by the error dumping mechanism, leading to confusing diagnostic output.
• Improved Logging: In dump_engine_exception, I've slightly improved the logging format and switched to logger.exception for reporting errors that occur during the dumping process itself, providing more context.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This PR correctly refines exception handling by changing BaseException to Exception in critical error handling paths. This is an important improvement as it prevents the application from inadvertently suppressing system-level signals like SystemExit or KeyboardInterrupt, leading to more robust behavior and clearer diagnostics. The move to logger.exception in dump_input.py also enhances debuggability by providing full tracebacks. These changes improve the overall stability and maintainability of the error handling mechanisms.

[mgoin]

LGTM