-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
[MISC] correct copy_blocks src_to_dists param type #19696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MISC] correct copy_blocks src_to_dists param type #19696
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @andyxning, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request contains a minor fix to correct a type annotation for a parameter used in the IPEX attention implementation's block copying logic. This improves the accuracy of the type information for the function signature.
Highlights
- Type Hint Correction: Corrected the type hint for the
src_to_dists
parameter in thecopy_blocks
method within the IPEX attention implementation fromDict[int, List[int]]
totorch.Tensor
.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request correctly changes the type hint for the src_to_dists
parameter in _PagedAttention.copy_blocks
from Dict[int, List[int]]
to torch.Tensor
. This is a good correction because:
- The
src_to_dists
parameter is passed as theblock_mapping
argument tovllm._custom_ops.copy_blocks
. - The
vllm._custom_ops.copy_blocks
function (and its underlying C++ implementation) expects this argument to be atorch.Tensor
.
This change aligns the type hint with the actual runtime usage, improving code clarity and aiding static analysis. The change also makes the signature consistent with other copy_blocks
implementations in the codebase, such as vllm.attention.ops.paged_attn.PagedAttention.copy_blocks
and vllm.attention.backends.ipex_attn.IpexAttnBackend.copy_blocks
.
I've added one comment regarding an unused *args
parameter in the method signature, which could be considered for removal to further simplify the code, though it's not directly related to the primary type fix of this PR.
bf25553
to
45bdc20
Compare
Signed-off-by: Andy Xie <andy.xning@gmail.com>
45bdc20
to
f6ca77d
Compare
Signed-off-by: Andy Xie <andy.xning@gmail.com>
Signed-off-by: Andy Xie <andy.xning@gmail.com> Signed-off-by: minpeter <kali2005611@gmail.com>
Signed-off-by: Andy Xie <andy.xning@gmail.com> Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Andy Xie <andy.xning@gmail.com>
Signed-off-by: Andy Xie <andy.xning@gmail.com>
Signed-off-by: Andy Xie <andy.xning@gmail.com>
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
Type fix for
copy_blocks
parametersrc_to_dists
.Test Plan
NA
Test Result
NA
(Optional) Documentation Update