-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
Adding "AMD: Plugin Tests" and "AMD: Weight Loading Multiple GPU Test - Large Models" to amdproduction. #19707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
2c864fa
to
a14658a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @Concurrensee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily aims to extend the continuous integration test suite by enabling existing 'Plugin Tests' to run on amdproduction
hardware. It also includes a related refactoring to a dummy attention backend, ensuring its compatibility with a more abstract interface, which supports the broader testing goals.
Highlights
- CI/CD Pipeline Expansion: The Buildkite pipeline has been updated to include
amdproduction
hardware for the 'Plugin Tests (2 GPUs)' step. This ensures that these critical plugin tests will now execute on bothamdexperimental
andamdproduction
environments, broadening test coverage for AMD hardware. - Test Infrastructure Refinement: A minor refactoring was performed in the
dummy_attention_backend.py
file. TheDummyAttentionBackend
class now inherits from the more abstractAttentionBackend
base class instead of the concreteFlashAttentionBackend
. This change likely improves the flexibility and maintainability of the dummy plugin used in testing, aligning it with a more generic interface.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to add "AMD: Plugin Tests" to the amdproduction
hardware target in the test pipeline. The change in .buildkite/test-pipeline.yaml
correctly reflects this.
However, a modification in tests/plugins/vllm_add_dummy_platform/vllm_add_dummy_platform/dummy_attention_backend.py
introduces a critical issue. By changing the base class of DummyAttentionBackend
to the abstract AttentionBackend
, several abstract methods are now unimplemented. This will cause TypeError
on instantiation, likely breaking tests that rely on this dummy backend, potentially impacting the new AMD plugin tests. This needs to be addressed by implementing the missing abstract methods.
tests/plugins/vllm_add_dummy_platform/vllm_add_dummy_platform/dummy_attention_backend.py
Outdated
Show resolved
Hide resolved
a14658a
to
68d26ed
Compare
Signed-off-by: Yida Wu <yida.wu@amd.com>
c7c9e66
to
75fa805
Compare
75fa805
to
8bfeda0
Compare
…weight loading tests to production Signed-off-by: Yida Wu <yida.wu@amd.com>
8bfeda0
to
3a88351
Compare
Adding "AMD: Plugin Tests" to amdproduction.