Skip to content

Remove sm120 arch from sm100 cutlass kernel arch list #19716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

Remove sm120 arch from sm100 cutlass kernel arch list #19716

merged 1 commit into from
Jun 17, 2025

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Jun 16, 2025 •
edited by github-actions bot
Loading

Purpose

The current CUTLASS kernels for Blackwell are sm100 specific, so there is no need to include sm120 in the potential arch list for them.

@mgoin
Remove sm120 arch from sm100 cutlass kernel
d1086d6 
Signed-off-by: mgoin <mgoin64@gmail.com>
@mgoin mgoin requested a review from tlrmchlsmth as a code owner June 16, 2025 22:45
@gemini-code-assist Gemini Code Assist
Copy link
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mgoin mgoin changed the title Remove sm120 arch from sm100 cutlass kernel Remove sm120 arch from sm100 cutlass kernel arch list Jun 16, 2025
@mgoin mgoin requested review from LucasWilkinson and tlrmchlsmth and removed request for tlrmchlsmth June 16, 2025 22:45
@mergify mergify bot added the ci/build label Jun 16, 2025
LucasWilkinson
LucasWilkinson approved these changes Jun 16, 2025
View reviewed changes
Copy link
Collaborator

@LucasWilkinson LucasWilkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for the cleanup!

@LucasWilkinson LucasWilkinson enabled auto-merge (squash) June 16, 2025 22:59
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 16, 2025
@simon-mo simon-mo disabled auto-merge June 17, 2025 18:49
@simon-mo simon-mo merged commit bf57ccc into vllm-project:main Jun 17, 2025
104 of 109 checks passed
yeqcharlotte pushed a commit to yeqcharlotte/vllm that referenced this pull request Jun 22, 2025
@mgoin @yeqcharlotte
Remove sm120 arch from sm100 cutlass kernel arch list (vllm-project#1…
1582bf2 
…9716)

Signed-off-by: mgoin <mgoin64@gmail.com>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
@mgoin @minpeter
Remove sm120 arch from sm100 cutlass kernel arch list (vllm-project#1…
d1a778b 
…9716)

Signed-off-by: mgoin <mgoin64@gmail.com>
Signed-off-by: minpeter <kali2005611@gmail.com>
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Jun 24, 2025
@mgoin @yangw-dev
Remove sm120 arch from sm100 cutlass kernel arch list (vllm-project#1…
732fe29 
…9716)

Signed-off-by: mgoin <mgoin64@gmail.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jun 30, 2025
@mgoin
Remove sm120 arch from sm100 cutlass kernel arch list (vllm-project#1…
54dd0c7 
…9716)

Signed-off-by: mgoin <mgoin64@gmail.com>
wseaton pushed a commit to wseaton/vllm that referenced this pull request Jun 30, 2025
@mgoin
Remove sm120 arch from sm100 cutlass kernel arch list (vllm-project#1…
01e15d3 
…9716)

Signed-off-by: mgoin <mgoin64@gmail.com>
avigny pushed a commit to avigny/vllm that referenced this pull request Jul 31, 2025
@mgoin @avigny
Remove sm120 arch from sm100 cutlass kernel arch list (vllm-project#1…
7452a13 
…9716)

Signed-off-by: mgoin <mgoin64@gmail.com>
Signed-off-by: avigny <47987522+avigny@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasWilkinson LucasWilkinson

@tlrmchlsmth tlrmchlsmth

Assignees
No one assigned
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgoin @LucasWilkinson @simon-mo