Skip to content

v1: Support KV events from connectors #19737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

orozery
Copy link
Contributor

@orozery orozery commented Jun 17, 2025

This PR adds a new scheduler-side connector API to collect KV cache events.
Additionally, we add a generic metadata field to KVCacheEvent to allow custom metadata on KV events.

Part of the work described in RFC #19854

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @orozery, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the KV cache event system by extending the connector API to allow connectors to emit KV cache events. It also introduces a flexible metadata field for KVCacheEvent objects and integrates the collection of these new connector-emitted events into the scheduler's event publishing mechanism.

Highlights

  • KVCacheEvent Metadata: Introduced a generic metadata: Optional[dict[str, Any]] field to the KVCacheEvent base class, allowing custom data to be associated with KV cache events. The KVCacheEvent dataclass was also updated to make its fields keyword-only.
  • New KV Event API for Connectors: Added a new take_events() method to the KVConnector base class. This method provides an API for connectors to expose KV cache events they collect, returning an optional list of KVCacheEvent objects.
  • Scheduler Event Aggregation: Updated the scheduler's schedule method to collect and publish KV cache events. It now aggregates events from both the existing kv_cache_manager and the newly introduced KVConnector.take_events() method, ensuring all relevant events are published.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@mergify mergify bot added the v1 label Jun 17, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR introduces a new scheduler-side connector API to collect KV cache events, along with a generic metadata field for KVCacheEvent. The changes look good, with a suggestion for optimizing list concatenation in the scheduler and a few minor suggestions for improved code clarity.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

This commit adds a new scheduler-side connector API
to collect KV cache events.
Additionally, we add a generic metadata field
to KVCacheEvent to allow custom metadata on KV events.

Signed-off-by: Or Ozeri <oro@il.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant