Skip to content

Fixing Chunked Prefill Test. #19762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2025
Merged

Conversation

Alexei-V-Ivanov-AMD
Copy link
Collaborator

@Alexei-V-Ivanov-AMD Alexei-V-Ivanov-AMD commented Jun 17, 2025

Fixing Chunked Prefill Test.

Signed-off-by: Alexei V. Ivanov alexei.ivanov@amd.com

Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @Alexei-V-Ivanov-AMD, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to fix failures in the Chunked Prefill Test suite by introducing conditional skips for tests that rely on features or attention backends not supported on ROCm platforms. This ensures the test suite's reliability and correctness across different hardware environments by avoiding unsupported test configurations.

Highlights

  • Test Stability on ROCm: I've added pytest.mark.skipif decorators to several test functions within test_chunked_prefill.py to prevent them from running on ROCm platforms when specific hardware-dependent features or attention backends are not supported. This ensures the test suite passes correctly on ROCm without attempting unsupported configurations.
  • FLASHINFER Backend Compatibility: The FLASHINFER attention backend is now conditionally skipped for both test_models (lines 53-56) and test_models_distributed (lines 109-112) when the test environment is detected as ROCm, as FLASHINFER is not supported on this platform.
  • FP8 KV Cache Compatibility: The test_models_with_fp8_kv_cache test (lines 187-188) is now skipped on ROCm platforms because the underlying machete_prepack_B functionality required for FP8 KV cache is not supported there.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively addresses test failures on ROCm platforms by conditionally skipping test configurations that rely on unsupported features. The changes are clear and use standard pytest mechanisms.

Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>
@mergify mergify bot added the ci/build label Jun 17, 2025
@simon-mo simon-mo enabled auto-merge (squash) June 17, 2025 18:50
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 17, 2025
@houseroad houseroad added the rocm Related to AMD ROCm label Jun 18, 2025
@vllm-bot vllm-bot merged commit 4719460 into vllm-project:main Jun 19, 2025
101 of 107 checks passed
yeqcharlotte pushed a commit to yeqcharlotte/vllm that referenced this pull request Jun 22, 2025
Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>
Signed-off-by: minpeter <kali2005611@gmail.com>
gmarinho2 pushed a commit to gmarinho2/vllm that referenced this pull request Jun 26, 2025
Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jun 30, 2025
Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>
wseaton pushed a commit to wseaton/vllm that referenced this pull request Jun 30, 2025
Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>
Signed-off-by: Will Eaton <weaton@redhat.com>
wseaton pushed a commit to wseaton/vllm that referenced this pull request Jun 30, 2025
Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>
wwl2755-google pushed a commit to wwl2755-google/vllm that referenced this pull request Jul 1, 2025
Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>
avigny pushed a commit to avigny/vllm that referenced this pull request Jul 31, 2025
Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>
Signed-off-by: avigny <47987522+avigny@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants