Skip to content

[AMD][P/D] Add libamdhip64.so.6 for llmd #19773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rasmith
Copy link
Contributor

@rasmith rasmith commented Jun 17, 2025

This PR adds a special version of libamdhip64.so.6 for compatibility with llmd. The usual version of this library needs a small modification to prevent NIXL / UCX from crashing due to a check inside of libamdhip64.so.6.

The official patch is expected to arrive in ROCm 7, but until that arrives, this library can be used.

Signed-off-by: Randall Smith <Randall.Smith@amd.com>
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the rocm Related to AMD ROCm label Jun 17, 2025
Copy link
Collaborator

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Directly adding the .so file here may not be the best way to patch.
Can we figure out a way to download the file also explain how to patch the file in which scenario?

@rasmith
Copy link
Contributor Author

rasmith commented Jun 18, 2025

Directly adding the .so file here may not be the best way to patch. Can we figure out a way to download the file also explain how to patch the file in which scenario?

The file is used in place of the existing .so that is in the docker that is to be used. Without this particular version of libamdhip64.so the current llm-d function will not work.

There might be other ways to make this work, but the first step for now is to add it directly into this repository so that the docker installation can simply copy the library from the repository itself and into the final destination in the docker direclty.

@youkaichao
Copy link
Member

There might be other ways to make this work, but the first step for now is to add it directly into this repository so that the docker installation can simply copy the library from the repository itself and into the final destination in the docker direclty.

I don't think we should put binaries in the vllm repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rocm Related to AMD ROCm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants