Skip to content

[Minor] Allow redirecting model path for HfRunner in test #19795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025

Conversation

Isotr0py
Copy link
Collaborator

@Isotr0py Isotr0py commented Jun 18, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Test Plan

VLLM_MODEL_REDIRECT_PATH="/data/redirect.json" pytest -s -v tests/models/multimodal/generation/test_common.py -k qwen2_vl

Test Result

  • The above test can pass with local model redirection on a machine without HF connection.

(Optional) Documentation Update

Signed-off-by: Isotr0py <2037008807@qq.com>
@Isotr0py Isotr0py requested a review from DarkLight1337 June 18, 2025 07:41
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @Isotr0py, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where HfRunner in the test suite did not respect local model path redirections, causing tests to fail on machines without an internet connection to Hugging Face. My changes ensure that HfRunner now correctly applies model path redirects, allowing for offline testing of models that rely on Hugging Face's AutoConfig and AutoModelForCausalLM.

Highlights

  • Enable Local Model Redirection for HfRunner: I've modified the HfRunner class in tests/conftest.py to utilize the maybe_model_redirect utility. This ensures that when the VLLM_MODEL_REDIRECT_PATH environment variable is set, HfRunner will attempt to redirect model paths to local copies, similar to how VllmRunner already behaves.
  • Import maybe_model_redirect: To support the model path redirection, I've added an import for maybe_model_redirect from vllm.transformers_utils.utils into tests/conftest.py.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a minor but useful enhancement to the HfRunner test utility. By incorporating the maybe_model_redirect function, it allows HfRunner to respect the VLLM_MODEL_REDIRECT_PATH environment variable, similar to VllmRunner. This change improves the testability of models in environments without direct Hugging Face Hub access by enabling the use of locally redirected model paths.

The changes are well-contained, leveraging an existing cached utility, and appear correct for the intended testing purpose. I found no issues of medium, high, or critical severity in this pull request.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) June 18, 2025 08:42
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 18, 2025
@mergify mergify bot added the qwen Related to Qwen models label Jun 18, 2025
@vllm-bot vllm-bot merged commit 6021999 into vllm-project:main Jun 19, 2025
57 of 59 checks passed
@Isotr0py Isotr0py deleted the redirect-test branch June 19, 2025 08:25
yeqcharlotte pushed a commit to yeqcharlotte/vllm that referenced this pull request Jun 22, 2025
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
…ct#19795)

Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: minpeter <kali2005611@gmail.com>
gmarinho2 pushed a commit to gmarinho2/vllm that referenced this pull request Jun 26, 2025
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jun 30, 2025
wseaton pushed a commit to wseaton/vllm that referenced this pull request Jun 30, 2025
…ct#19795)

Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Will Eaton <weaton@redhat.com>
wseaton pushed a commit to wseaton/vllm that referenced this pull request Jun 30, 2025
wwl2755-google pushed a commit to wwl2755-google/vllm that referenced this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants