-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
[Bugfix] Add check_health to v1 async client. #19821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Add check_health to v1 async client. #19821
Conversation
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @kouroshHakha, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request implements a critical bug fix by restoring and enhancing the check_health
functionality for the v1
asynchronous client. This change ensures that the client can accurately reflect the operational status of the engine, which was identified as a gap during recent fault-tolerance testing. It includes both the core logic implementation and comprehensive test coverage.
Highlights
- Bugfix: Re-introducing Health Check: This pull request addresses a bug by re-introducing the
check_health
method to thev1
asynchronous client (AsyncLLM
), which was inadvertently omitted during the V1 migration. This ensures the client can properly report the health status of the underlying engine. - Enhanced Health Check Logic: The
check_health
method invllm/v1/engine/async_llm.py
has been updated to raiseself.dead_error
if the engine'serrored
property is true, providing a clear indication when the engine is in a non-recoverable state. - Comprehensive Test Coverage: A new asynchronous test case,
test_check_health
, has been added totests/v1/engine/test_async_llm.py
. This test thoroughly validates thecheck_health
method's behavior, covering scenarios for both healthy and simulated 'dead' engine states to ensure robustness.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request implements the check_health
method in the V1 AsyncLLM
client, which checks the engine's errored
status and raises an EngineDeadError
if the engine is not healthy. A new test case has been added to verify this functionality. The implementation is correct, and the test effectively validates the new logic.
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com> Signed-off-by: minpeter <kali2005611@gmail.com>
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com> Signed-off-by: Will Eaton <weaton@redhat.com>
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
This was missed from the V1 migration and we just noticed it when doing fault-tolerance tests on P/D.