Skip to content

[Bugfix] Fix the linter #19826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025
Merged

[Bugfix] Fix the linter #19826

merged 1 commit into from
Jun 19, 2025

Conversation

houseroad
Copy link
Collaborator

@houseroad houseroad commented Jun 19, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

pre-commit failed, such as https://github.com/vllm-project/vllm/actions/runs/15746407075/job/44383409747.

Fix the linter

Test Plan

CI

Test Result

Passed

(Optional) Documentation Update

N/A

Signed-off-by: Lu Fang <lufang@fb.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes linter issues by reformatting multiline function calls in the get_hf_processor method across multiple modules.

  • Corrected the argument formatting for the image_processor parameter
  • Standardized indentation and line breaks in the affected function calls

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
vllm/model_executor/models/qwen2_vl.py Reformatted the image_processor call for consistent linter compliance
vllm/model_executor/models/qwen2_5_vl.py Adjusted argument formatting in the image_processor call
vllm/model_executor/models/qwen2_5_omni_thinker.py Reorganized line breaks and indentation for image_processor parameters

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @houseroad, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily addresses and resolves existing linter failures by applying targeted code formatting changes. The modifications are purely cosmetic, focusing on aligning argument formatting in specific function calls to adhere to the project's established coding style guidelines.

Highlights

  • Linter Fixes: Applied automatic code formatting to resolve pre-commit linter failures, as indicated by the PR title and description.
  • Code Style Consistency: Standardized the argument formatting for the image_processor parameter within self.get_image_processor calls across three Qwen2-related model files: qwen2_5_omni_thinker.py, qwen2_5_vl.py, and qwen2_vl.py. This involved consolidating multi-line arguments into a single line for each instance.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@mergify mergify bot added the qwen Related to Qwen models label Jun 19, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request addresses linting issues by reformatting the arguments of self.get_image_processor in three files for better readability. The changes are straightforward and improve code style.

@houseroad houseroad added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 19, 2025
@WoosukKwon WoosukKwon disabled auto-merge June 19, 2025 04:44
@WoosukKwon WoosukKwon merged commit b1098b4 into vllm-project:main Jun 19, 2025
74 of 80 checks passed
@WoosukKwon
Copy link
Collaborator

Sorry for the bug and thanks for the fix!

yeqcharlotte pushed a commit to yeqcharlotte/vllm that referenced this pull request Jun 22, 2025
Signed-off-by: Lu Fang <lufang@fb.com>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
Signed-off-by: Lu Fang <lufang@fb.com>
Signed-off-by: minpeter <kali2005611@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants