[Do not merge] Cache model info for faster startup #19837
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @WoosukKwon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request, marked as a work-in-progress, implements a caching layer for model metadata within the vllm model executor. The primary objective is to enhance performance by providing a shortcut to retrieve model information for specific architectures, thereby avoiding the overhead of subprocess calls that would otherwise be required for model inspection.
Highlights
- Performance Optimization: Introduced a caching mechanism for
_ModelInfoobjects to avoid potentially expensive subprocess calls when inspecting known model architectures. This aims to speed up model information retrieval. - Hardcoded Model Information: Added a hardcoded
_ModelInfoinstance for the 'Qwen2_5_VLForConditionalGeneration' model, pre-defining its characteristics (e.g.,is_text_generation_model,supports_multimodal). - Conditional Inspection Logic: Modified the
_try_inspect_model_clsmethod to first check a newCACHED_MODEL_INFOdictionary. If the model architecture is found in the cache, its information is returned immediately, bypassing the original inspection logic.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a mechanism to cache model information for Qwen2_5_VLForConditionalGeneration to bypass subprocess calls during model inspection, aiming for a performance improvement. The main feedback points concern the maintainability and correctness of this hardcoded cache.
| # NOTE(woosuk): A shortcut to get model info without subprocess call. | ||
| # This needs to be updated whenever the model definition changes. |
There was a problem hiding this comment.
This shortcut to get model info without subprocess call requires manual updates whenever the model definition changes. Consider implementing a CI check or a test that dynamically inspects the model properties and asserts they match the cached values to catch inconsistencies early.
| CACHED_MODEL_INFO = { | ||
| "Qwen2_5_VLForConditionalGeneration": QWEN2_5_VL_MODEL_INFO, |
There was a problem hiding this comment.
Consider using a more generic key than the specific model class name to make the cache more reusable.
WoosukKwon
changed the title
A hacky way to save ~6 secs in startup time.