-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
[Bugfix] Fix bnb 8bit model weights loading #19917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Isotr0py <2037008807@qq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @Isotr0py, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request provides a critical bug fix for loading BitsAndBytes (BNB) 8-bit quantized models, which previously failed due to a type mismatch during the dequantization process. The change ensures robust model loading by adding a necessary type check, thereby restoring compatibility and functionality for these models.
Highlights
- Bugfix: Addressed an
AttributeError
that occurred when loading BitsAndBytes (BNB) 8-bit pre-quantized models. The error,AttributeError: 'Tensor' object has no attribute 'nested'
, was resolved by ensuring that thequant_state
object is an instance ofQuantState
before attempting to access itsnested
attribute.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively addresses a critical bug that caused an AttributeError
when loading BNB 8-bit pre-quantized models. The error occurred because the dequantize_dq
function attempted to access a .nested
attribute on a torch.Tensor
object, which was not always a bitsandbytes.functional.QuantState
instance as expected.
The fix introduces a type check using isinstance(quant_state, QuantState)
before accessing the .nested
attribute. This ensures that the attribute is only accessed if quant_state
is indeed a QuantState
object, thereby preventing the crash. The necessary QuantState
import has also been correctly added.
The change is well-targeted and directly resolves the reported issue, improving the robustness of the bitsandbytes model loader.
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fixing
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com> Signed-off-by: juncheoll <th6re8e@naver.com>
Signed-off-by: Isotr0py <2037008807@qq.com> Signed-off-by: fhl <2410591650@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com> Signed-off-by: Will Eaton <weaton@redhat.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
Test Plan
Test Result
The offline generation should run successfully and bnb 8bit tests should pass now.
(Optional) Documentation Update