Skip to content

Add index() function to CSS package #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2025
Merged

Add index() function to CSS package #1588

merged 2 commits into from
Jun 17, 2025

Conversation

tidoust
Copy link
Member

@tidoust tidoust commented Jun 16, 2025

The function creates an indexed structure more aligned with MDN data. The README documentation was also updated to detail remaining structural nuances, and more importantly differences in content between the two projects.

The function creates an indexed structure more aligned with MDN data. The
README documentation was also updated to detail remaining structural nuances,
and more importantly differences in content between the two projects.
@tidoust tidoust requested a review from dontcallmedom June 17, 2025 08:51
@tidoust
Copy link
Member Author

tidoust commented Jun 17, 2025

The CI test failure is unrelated, but I still need to understand why it gets raised. As far as I can tell, the problematic type was introduced in main after that pull request got created and tests should not run against data in main.

I do see a minor flaw in the code that applies "freeze" patches (the code assumes that it needs to return to main afterwards). But that should not have much consequences on top of leaving the client on the wrong branch afterwards.

@tidoust tidoust force-pushed the css-index branch 2 times, most recently from c251eac to cf892ff Compare June 17, 2025 10:51
@tidoust
Copy link
Member Author

tidoust commented Jun 17, 2025

The CI test failure is unrelated, but I still need to understand why it gets raised. As far as I can tell, the problematic type was introduced in main after that pull request got created and tests should not run against data in main.

And now I understand. For some reason, I assumed that the checkout action in a pull request checked out the data at the latest PR commit. It actually performs a merge with the main branch, which explains why the (unrelated) error appears.

I do see a minor flaw in the code that applies "freeze" patches (the code assumes that it needs to return to main afterwards). But that should not have much consequences on top of leaving the client on the wrong branch afterwards.

That flaw does exist, and indeed does not have much consequences. I'll fix it in another PR.

@tidoust tidoust merged commit 1fe5ddc into main Jun 17, 2025
0 of 2 checks passed
@tidoust tidoust deleted the css-index branch June 17, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants