Define an optional value and use it for setting dialog returnValue #11280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define a new 'optional value' for buttons and submit inputs, this is used instead of 'value' when setting a dialog's returnValue.
|
@annevk hopefully this is roughly what you had in mind? |
6 tasks
annevk
reviewed
May 2, 2025
Add submit button check. ought to be used*
lukewarlow
force-pushed
the
form-submit-returnvalue-fix
branch
from
a54c9f8 to
cadc51c
Compare
annevk
approved these changes
May 12, 2025
|
Thanks for the review, this should be ready to go |
annevk
approved these changes
May 22, 2025
annevk
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 22, 2025
We now assert the actual value of returnValue when the submit button has no attribute. See whatwg/html#11280.
annevk
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 22, 2025
lando-prod-mozilla bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
May 23, 2025
Automatic update from web-platform-tests Update dialog form submission test We now assert the actual value of returnValue when the submit button has no attribute. See whatwg/html#11280. -- wpt-commits: 76c3c693ab36c5a7eb523ec798d60cfd57379423 wpt-pr: 51484 Differential Revision: https://phabricator.services.mozilla.com/D251003
lando-prod-mozilla bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
May 23, 2025
…mmand buttons, Automatic update from web-platform-tests Add more dialog returnValue tests for command buttons See whatwg/html#11280. -- wpt-commits: 975e4f6ae35d7390beab0ba0c871a349f15ea87e wpt-pr: 52278 Differential Revision: https://phabricator.services.mozilla.com/D251005
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 24, 2025
Automatic update from web-platform-tests Update dialog form submission test We now assert the actual value of returnValue when the submit button has no attribute. See whatwg/html#11280. -- wpt-commits: 76c3c693ab36c5a7eb523ec798d60cfd57379423 wpt-pr: 51484 Differential Revision: https://phabricator.services.mozilla.com/D251003
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 24, 2025
…mmand buttons, Automatic update from web-platform-tests Add more dialog returnValue tests for command buttons See whatwg/html#11280. -- wpt-commits: 975e4f6ae35d7390beab0ba0c871a349f15ea87e wpt-pr: 52278 Differential Revision: https://phabricator.services.mozilla.com/D251005
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
May 26, 2025
Automatic update from web-platform-tests Update dialog form submission test We now assert the actual value of returnValue when the submit button has no attribute. See whatwg/html#11280. -- wpt-commits: 76c3c693ab36c5a7eb523ec798d60cfd57379423 wpt-pr: 51484 Differential Revision: https://phabricator.services.mozilla.com/D251003
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
May 26, 2025
…mmand buttons, Automatic update from web-platform-tests Add more dialog returnValue tests for command buttons See whatwg/html#11280. -- wpt-commits: 975e4f6ae35d7390beab0ba0c871a349f15ea87e wpt-pr: 52278 Differential Revision: https://phabricator.services.mozilla.com/D251005
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
May 28, 2025
Automatic update from web-platform-tests Update dialog form submission test We now assert the actual value of returnValue when the submit button has no attribute. See whatwg/html#11280. -- wpt-commits: 76c3c693ab36c5a7eb523ec798d60cfd57379423 wpt-pr: 51484 Differential Revision: https://phabricator.services.mozilla.com/D251003 UltraBlame original commit: 984064be0606698b570273a83a79d2fda0276504
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
May 28, 2025
…mmand buttons, Automatic update from web-platform-tests Add more dialog returnValue tests for command buttons See whatwg/html#11280. -- wpt-commits: 975e4f6ae35d7390beab0ba0c871a349f15ea87e wpt-pr: 52278 Differential Revision: https://phabricator.services.mozilla.com/D251005 UltraBlame original commit: 4df6b216f6a259ee1077dafe848ddcfde0d8c807
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
May 28, 2025
Automatic update from web-platform-tests Update dialog form submission test We now assert the actual value of returnValue when the submit button has no attribute. See whatwg/html#11280. -- wpt-commits: 76c3c693ab36c5a7eb523ec798d60cfd57379423 wpt-pr: 51484 Differential Revision: https://phabricator.services.mozilla.com/D251003 UltraBlame original commit: 984064be0606698b570273a83a79d2fda0276504
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
May 28, 2025
…mmand buttons, Automatic update from web-platform-tests Add more dialog returnValue tests for command buttons See whatwg/html#11280. -- wpt-commits: 975e4f6ae35d7390beab0ba0c871a349f15ea87e wpt-pr: 52278 Differential Revision: https://phabricator.services.mozilla.com/D251005 UltraBlame original commit: 4df6b216f6a259ee1077dafe848ddcfde0d8c807
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
May 28, 2025
Automatic update from web-platform-tests Update dialog form submission test We now assert the actual value of returnValue when the submit button has no attribute. See whatwg/html#11280. -- wpt-commits: 76c3c693ab36c5a7eb523ec798d60cfd57379423 wpt-pr: 51484 Differential Revision: https://phabricator.services.mozilla.com/D251003 UltraBlame original commit: 984064be0606698b570273a83a79d2fda0276504
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
May 28, 2025
…mmand buttons, Automatic update from web-platform-tests Add more dialog returnValue tests for command buttons See whatwg/html#11280. -- wpt-commits: 975e4f6ae35d7390beab0ba0c871a349f15ea87e wpt-pr: 52278 Differential Revision: https://phabricator.services.mozilla.com/D251005 UltraBlame original commit: 4df6b216f6a259ee1077dafe848ddcfde0d8c807
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define a new 'optional value' for buttons and submit inputs, this is used instead of 'value' when setting a dialog's returnValue.
Fixes #11092
(See WHATWG Working Mode: Changes for more details.)
/form-control-infrastructure.html ( diff )
/form-elements.html ( diff )
/input.html ( diff )
/interactive-elements.html ( diff )