Test fixes #426
Merged
Test fixes #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise it's specs would be loaded / run out of context leading to
many errors like this:
1) Error:
TagExamples::from empty db::lowest_common_ancestor#test_0009_is itself for single item:
NameError: uninitialized class variable @@described_class in TagExamples
Did you mean? describe
/closure_tree/test/support/tag_examples.rb:10:in `block (2 levels) in <module:TagExamples>'
when trying to run a single test, i.e.
bundle exec rake test TESTOPTS="--seed=10410" TEST=test/closure_tree/parallel_test.rb
- same as specs, fixes parallel_test
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to run the tests locally, I had to make a few changes to make things work:
MiniTesthas apparently been renamed toMinitestat some point (this apparently also broke the most recent CI runs)force: :cascadeso the recreation of the schema does not fail because of dependencies (at least on PostgreSQL)tag_examplesmodule was evaluated as actual tests while trying to run any different test file, leading to hundreds of errors. Just requiring it where it's needed seems to help with that.Now I am at the point where all tests except the parallel_test are running fine, but that's a separate topic :)