Fix parameter name in exception for case when Kernel has custom names… #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TavoNiievez
requested changes
Mar 9, 2025
| @@ -299,7 +299,7 @@ protected function getKernelClass(): string | |||
| throw new ModuleRequireException( | |||
| self::class, | |||
| "File with Kernel class was not found at {$path}.\n" | |||
| . 'Specify directory where file with Kernel class for your application is located with `app_path` parameter.' | |||
| . 'Specify directory where file with Kernel class for your application is located with `kernel_class` parameter.' | |||
There was a problem hiding this comment.
it seems that in this specific message we are really waiting for the app_path.
In the message you fixed below it is correct to change to kernel_class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pace