Make the node catalog, originating from a wire dropped in the graph, filter for valid types #2423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send InputTypes through SendUiMetadata under odeTypes. Update NodeCatalog.svelte component to support ype based filtering. Update ContextMenuData to support compatibleType as an input to the searchTerm for the NodeCatalog. Update Graph.svelte component to support new ContextMenuData enum types. Send CompatibleType data from rust backend on wire drag and release to NodeCatalog to already show filtered data.
Send InputTypes through SendUiMetadata under odeTypes. Update NodeCatalog.svelte component to support ype based filtering. Update ContextMenuData to support compatibleType as an input to the searchTerm for the NodeCatalog. Update Graph.svelte component to support new ContextMenuData enum types. Send CompatibleType data from rust backend on wire drag and release to NodeCatalog to already show filtered data.
…ite into filter-node-catalog
|
@Keavon @0HyperCube please review. |
singhutsav5502
changed the title
Keavon
changed the title
|
Hi, it passes the test after merge as well. |
|
Hi, @Keavon please review. |
|
0HyperCube
requested changes
Mar 14, 2025
editor/src/messages/portfolio/document/node_graph/document_node_definitions.rs
Show resolved
Hide resolved
| @@ -82,7 +99,7 @@ | |||
| </script> | |||
|
|
|||
| <div class="node-catalog"> | |||
| <TextInput placeholder="Search Nodes..." value={searchTerm} on:value={({ detail }) => (searchTerm = detail)} bind:this={nodeSearchInput} /> | |||
| <TextInput placeholder="Search Nodes... (or type:InputType)" value={searchTerm} on:value={({ detail }) => (searchTerm = detail)} bind:this={nodeSearchInput} /> | |||
There was a problem hiding this comment.
I'm not quite sure of the UX of having the type as the search term. This prevents the user from further filtering down the options.
For example vector data is used by many nodes (and more will be added over time), so the user may wish to further filter them with a keyword.
There was a problem hiding this comment.
Hi, @0HyperCube pushed code changes that adds support for simultaneous type, category and node name search.
|
Marking as a draft while awaiting changes. Please switch back when ready. |
… sending metadata. Update NodeCatalog Search filter to support single type search alongside name and category search
|
Hi @Keavon pushed some changes, that should close this issue unless i overlooked something. |
…Update missing categories and make sure to remove nodes with empty categories
|
Hi, @0HyperCube please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add InputType based filtering capabilites to NodeCatalog.
SendUiMetadataundernodeTypes.NodeCatalog.sveltecomponent to supporttypebased filtering.compatibleTypeas an input to the searchTerm for the NodeCatalog.Graph.sveltecomponent to support new ContextMenuData enum types.Adds functionality to open NodeCatalog on
DoubleClickinput ( in empty node graph area. )Closes #2359