Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Convex Hull node #2436

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add Convex Hull node #2436

wants to merge 1 commit into from

Conversation

MixedMatched
Copy link

Closes #1673

Creates a convex hull node using a gift wrapping algorithm.

This PR still needs a couple "fixes" for Bézier curves:

  • Gift wrap needs to check whether a given point is left of a given segment. That check needs to be updated to be for Bézier curves instead of lines.
  • Instead of Bézier curves going beyond the convex hull, they need to be cut and added to the hull (issue shown below).

Screenshot from Graphite showing a black-stroked ellipse, rectangle, and pentagon surrounded by a red hull. Part of the ellipse is outside the hull because it's overlapping with the rectangle.

@Keavon
Copy link
Member

Keavon commented Mar 14, 2025

Welcome! Glad to see the beginnings of progress towards this :)

@Keavon Keavon marked this pull request as draft March 15, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convex Hull node
2 participants
@MixedMatched @Keavon