[Feature] Itbl code coverage #731
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LNotification.java' and 'IterableApi.java'
Itbl code coverage
Ayyanchira
requested changes
Mar 20, 2025
Comment on lines
+132
to
+146
| public void testOnCreateWithValidArgs() { | ||
| IterableInAppManager mockInAppManager = mock(IterableInAppManager.class); | ||
| when(mockIterableApi.getInAppManager()).thenReturn(mockInAppManager); | ||
|
|
||
| when(mockBundle.getString("HTML", null)).thenReturn("html content"); | ||
| when(mockBundle.getBoolean("CallbackOnCancel", false)).thenReturn(true); | ||
| when(mockBundle.getString("MessageId")).thenReturn("message123"); | ||
| when(mockBundle.getDouble("BackgroundAlpha")).thenReturn(0.7); | ||
|
|
||
| htmlNotification.setArguments(mockBundle); | ||
| htmlNotification.onCreate(null); | ||
|
|
||
| assertEquals("message123", "message123"); | ||
| assertTrue(true); | ||
| } |
There was a problem hiding this comment.
This is not making sense. Its asserting string value to string value.
Comment on lines
+148
to
+162
| @Test | ||
| public void testOnCreateWithNullArgs() { | ||
| htmlNotification.onCreate(null); | ||
| assertEquals("message123", "message123"); | ||
| assertFalse(false); | ||
| } | ||
|
|
||
| @Test | ||
| public void testSetLoaded() { | ||
| assertFalse(false); | ||
| htmlNotification.setLoaded(true); | ||
| assertTrue(true); | ||
| htmlNotification.setLoaded(false); | ||
| assertFalse(false); | ||
| } |
There was a problem hiding this comment.
These methods are not testing anything
Comment on lines
+172
to
+179
| public void testOnDestroy() { | ||
| if (htmlNotification.getActivity() != null && htmlNotification.getActivity().isChangingConfigurations()) { | ||
| return; | ||
| } | ||
| htmlNotification.onDestroy(); | ||
| htmlNotification = null; | ||
| location = null; | ||
| } |
There was a problem hiding this comment.
after destruction, its not asserting anything?
Comment on lines
+187
to
+196
| public void testResize_ExceptionHandling() { | ||
| AlertDialog dialogMock = Mockito.mock(AlertDialog.class); | ||
| Window windowMock = Mockito.mock(Window.class); | ||
|
|
||
| when(htmlNotification.getDialog()).thenReturn(dialogMock); | ||
| when(dialogMock.getWindow()).thenReturn(windowMock); | ||
|
|
||
| doThrow(new IllegalArgumentException("Test Exception")).when(windowMock).setLayout(anyInt(), anyInt()); | ||
| htmlNotification.resize(0.5f); | ||
| } |
There was a problem hiding this comment.
Whenever, we do a - do().when()
Its basically a setup.
That setup is used to then check if if the setup was followed due to invocation of some methods that we want to test. Here, we are missing that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s) if any
✏️ Description