Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added spotless #12

Merged
merged 7 commits into from
Oct 3, 2024
Merged

added spotless #12

merged 7 commits into from
Oct 3, 2024

Conversation

Taz03
Copy link
Contributor

@Taz03 Taz03 commented Oct 1, 2024 •
edited
Loading

closes #11

@navin772
Copy link
Member

navin772 commented Oct 2, 2024

Thanks for the PR @Taz03 , can you add some steps (even if it is single command) for formatting in the README file to run spotless.
Also, create a new CI that would check for formatting and pass/fail based on push/PR.

@Taz03
Copy link
Contributor Author

Taz03 commented Oct 2, 2024 •
edited
Loading

on it, mb i forgot to make this pr a draft

@Taz03 Taz03 marked this pull request as draft October 2, 2024 04:02
@Taz03 Taz03 marked this pull request as ready for review October 2, 2024 04:14
Delta456
Delta456 reviewed Oct 2, 2024
View reviewed changes
@navin772
Copy link
Member

navin772 commented Oct 3, 2024

@Taz03 can you please resolve the conflicts?

harsha509
harsha509 approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Delta456
Delta456 approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@Delta456 Delta456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @Taz03! Thanks for your contributions :)

I will be merging this now 🌟

@Delta456 Delta456 merged commit 8cbdbb6 into LambdaTest:main Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navin772 navin772

@harsha509 harsha509

@Delta456 Delta456

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup Java Formatter Checks Using Checkstyle/Spotless in CI
4 participants
@Taz03 @navin772 @harsha509 @Delta456