Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Log4j #13

Merged
merged 6 commits into from
Oct 3, 2024
Merged

Migrate to Log4j #13

merged 6 commits into from
Oct 3, 2024

Conversation

subhramit
Copy link
Contributor

Closes #7

Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @subhramit ,

Thank you for the PR!

I see that latest log4j is 2.24.1, is there any specific reason that you've picked 2.14.1 which is 3 years old!

Thanks,
Sri

@subhramit
Copy link
Contributor Author

HI @subhramit ,

Thank you for the PR!

I see that latest log4j is 2.24.1, is there any specific reason that you've picked 2.14.1 which is 3 years old!

Thanks,
Sri

Hey, thanks for pointing that out!
You're right, I picked up the dependency lines from an old project template, and forgot to update it after being done with the changes.
I'll push a commit soon.

subhramit and others added 3 commits October 3, 2024 09:28
Co-authored-by: Sri Harsha <12621691+harsha509@users.noreply.github.com>
Co-authored-by: Sri Harsha <12621691+harsha509@users.noreply.github.com>
@subhramit subhramit requested a review from harsha509 October 3, 2024 03:59
Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @subhramit !

Co-authored-by: Navin Chandra <98466550+navin772@users.noreply.github.com>
@subhramit subhramit requested a review from navin772 October 3, 2024 05:34
@navin772 navin772 merged commit 1afe8a2 into LambdaTest:main Oct 3, 2024
@navin772
Copy link
Member

navin772 commented Oct 3, 2024

@subhramit Thank you for your contribution, and congratulations on having your PR accepted for Hacktoberfest! 🎉 Your effort helps improve the project, and we're excited to have contributors like you onboard.
Keep up the great work, and happy coding! 😊💻

@subhramit
Copy link
Contributor Author

@subhramit Thank you for your contribution, and congratulations on having your PR accepted for Hacktoberfest! 🎉 Your effort helps improve the project, and we're excited to have contributors like you onboard. Keep up the great work, and happy coding! 😊💻

Thank you so much! Hope to learn more from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Logging Framework (Log4j) for Better Logging
3 participants