simplify internal_itp #1127
Merged
simplify internal_itp #1127
+35
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscardssmith
force-pushed
the
os/simplify-itp
branch
from
e1f8a13 to
09ea438
Compare
oscardssmith
commented
Mar 26, 2025
| k1 = T(alg.k1) | ||
| k2 = T(alg.k2) | ||
| span = abs(right - left) | ||
| k1 = T(alg.scaled_k1)/span |
There was a problem hiding this comment.
do you know if the lack of scaling based on span was intentional here? The NonlinearSolveBase verison already had it.
|
I think this is ready now (but I have started nuking CI from orbit with ForwardDiff PRs so we'll see if CI here ever completes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to match SciML/NonlinearSolve.jl#548 (although this also fixes
k2to2since paying for a Floating point pow is expensive.Do not merge until SciML/NonlinearSolve.jl#548 is merged.