Mcp #899
Closed
Mcp #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conversation add title query
merge latest code
merge latest code
|
It's a really big PR. We would better have some unit tests to cover these changes. Or split it into multiple small PRs. |
kerryjiang
reviewed
Feb 27, 2025
| } | ||
|
|
||
| var properties = tool.InputSchema?.Properties; | ||
| var required = tool.InputSchema?.Required ?? new List<string>(); |
There was a problem hiding this comment.
Is the list readonly? If yes, just use singleton Array.Empty() here.
There was a problem hiding this comment.
list not readonly
kerryjiang
reviewed
Feb 27, 2025
| var isConvMode = conv.IsConversationMode(); | ||
| if (!isConvMode) return; | ||
|
|
||
| agent.SecondaryFunctions ??= []; |
kerryjiang
reviewed
Feb 27, 2025
| var mcps = agent.McpTools; | ||
| foreach (var item in mcps) | ||
| { | ||
| var ua = mcpClientManager.Factory.GetClientAsync(item.ServerId).Result; |
There was a problem hiding this comment.
Two async=>sync here, suggest having a async method and do async to sync only in one place
merge with main
1、Json Data Save to State 2、mcpdotnet with source ref
mcpdotnet now is mcp offical sdk
use ModelContextProtocol nuget package replace source ref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.