-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ref config #8984
base: dev
Are you sure you want to change the base?
Ref config #8984
Conversation
…set path of ref_config, then you can use __st_config_ref_key__ in source\transform\sink to merge ref config.
source { | ||
Jdbc { | ||
__st_config_ref_key__ = "mysql_prod" | ||
query="select * from department" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the code, looks if the mysql_prod
ref config also contains query
parameter, it will overwrite the existed query
parameter.
pluginConfig.withoutPath("__st_config_ref_key__").withFallback(refConfig);
Please add the priority for replacements when there are duplicate parameters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it
We can just describe it in the document to let use know this thing. Replace behavior is good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已经补充了配置优先级。
…nces and add descriptions of ref configuration and plugin configuration priorities.
Please add test case |
thanks to @hailin0 https://github.com/hailin0.
reference the design:
#8945 (comment)
Does this PR introduce any user-facing change?
yes
user can use ref config file to reuse config in job config file.
#8941
How was this patch tested?
Check list
New License Guide
release-note
.