Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref config #8984

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

Ref config #8984

wants to merge 7 commits into from

Conversation

thirsd
Copy link

@thirsd thirsd commented Mar 16, 2025

thanks to @hailin0 https://github.com/hailin0.

reference the design:
#8945 (comment)

Does this PR introduce any user-facing change?

yes
user can use ref config file to reuse config in job config file.

#8941

How was this patch tested?

  1. i have tested unset ref file .
  2. i have tested set ref file and use in mysql to console and sqlite to console.

Check list

thirsd added 4 commits March 15, 2025 20:20
…set path of ref_config, then you can use __st_config_ref_key__ in source\transform\sink to merge ref config.
source {
Jdbc {
__st_config_ref_key__ = "mysql_prod"
query="select * from department"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the code, looks if the mysql_prod ref config also contains query parameter, it will overwrite the existed query parameter.

pluginConfig.withoutPath("__st_config_ref_key__").withFallback(refConfig);

Please add the priority for replacements when there are duplicate parameters.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it

We can just describe it in the document to let use know this thing. Replace behavior is good to me.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经补充了配置优先级。

@liunaijie
Copy link
Member

Please add test case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api core SeaTunnel core module document Zeta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants