fix: fixing lint issues

Author: khushhalm

Access/access_modules/base_email_access/__init__.py

@@ -1 +1 @@
-from . import access
+from . import access # noqa

Access/access_modules/base_email_access/access.py

@@ -1,5 +1,4 @@
-from django.shortcuts import render, redirect
-import json
+from django.shortcuts import render
 import logging
 import traceback
 
@@ -9,6 +8,7 @@
 
 logger = logging.getLogger(__name__)
 
+
 # Use this base module when the access requires only sending a mail
 # to multiple dedicated emails
 # for super to work in python 2
@@ -24,9 +24,11 @@ def revoke_owner(self):
 
     # Override in module for specific person who should mark access as revoked
     def access_mark_revoke_permission(self, access_type):
+        # TODO: define ACCESS_REVOKE_PERMISSIONS_MAPPING
         return ACCESS_REVOKE_PERMISSIONS_MAPPING["security"]
 
-    # module's tag() method should return a tag present in hash returned by access_types() "type" key
+    # module's tag() method should return a tag present in
+    # hash returned by access_types() "type" key
     def get_label_desc(self, access_label):
         data = next(
             (
@@ -154,6 +156,7 @@ def approve(
             logger.error(
                 "Could not send email for error %s", str(traceback.format_exc())
             )
+            logger.error(e)
             return False, str(traceback.format_exc())
 
     def revoke(self, user, label):

bootprocess/admin.py

@@ -10,6 +10,7 @@
     MembershipV2,
 )
 
+admin.site.register(User)
 admin.site.register(Permission)
 admin.site.register(UserAccessMapping)
 admin.site.register(Role)

bootprocess/views_helper.py

@@ -79,7 +79,6 @@ def getDashboardData(request):
     ec2_regions = list(data.keys())
 
     context = {}
-    dataList = []
 
     gitCount = 0
     dashboardCount = 0

scripts/clone_access_modules.py

@@ -16,7 +16,8 @@
                 Repo(folder_path).remotes.origin.pull()
             else:
                 Repo.clone_from(url, folder_path)
-                # move all folders, not files in the cloned repo to the access_modules folder except the .git, .github and secrets folder
+                # move all folders, not files in the cloned repo to the access_modules
+                # folder except the .git, .github and secrets folder
                 for file in os.listdir(folder_path):
                     if (
                         os.path.isdir(folder_path + "/" + file)
@@ -28,8 +29,10 @@
                             folder_path + "/" + file, "./Access/access_modules/" + file
                         )
 
-                # remove the cloned repo folder entirely with all its contents which includes folders and files using shutil.rmtree()
-                # shutil.rmtree() sometimes throws an error on windows, so we use try and except to ignore the error
+                # remove the cloned repo folder entirely with all its contents which
+                # includes folders and files using shutil.rmtree()
+                # shutil.rmtree() sometimes throws an error on windows,
+                # so we use try and except to ignore the error
                 try:
                     shutil.rmtree(folder_path)
                 except Exception as e: