-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shared-db #1717
base: main
Are you sure you want to change the base?
shared-db #1717
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linting Errors
- guides/deployment/shared-db.md:86 Fenced code blocks should have a language specified
- guides/deployment/shared-db.md:186 Fenced code blocks should have a language specified
- guides/deployment/shared-db.md:255 Fenced code blocks should have a language specified
- guides/deployment/shared-db.md:415 Fenced code blocks should have a language specified
- guides/deployment/shared-db.md:423 Fenced code blocks should have a language specified
Spelling Mistakes
- guides/deployment/shared-db.md:13:28 Unknown word "microserivces"
- guides/deployment/shared-db.md:38:40 Unknown word "Clound"
- guides/deployment/shared-db.md:56:30 Unknown word "esample"
- guides/deployment/shared-db.md:247:3 Unknown word "Authentification"
- guides/deployment/shared-db.md:287:43 Unknown word "asynchronious"
- guides/deployment/shared-db.md:384:4 Unknown word "authentification"
- guides/deployment/shared-db.md:398:29 Unknown word "earch"
- guides/deployment/shared-db.md:439:23 Unknown word "authentification"
Generally, for each spelling mistake there are 2 ways to fix it:
- Fix the spelling mistake and commit it.
- The word is incorrectly reported as misspelled → put the word on the project-words.txt list, located in the root project directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linting Errors
- guides/deployment/shared-db.md:90 Fenced code blocks should have a language specified
- guides/deployment/shared-db.md:190 Fenced code blocks should have a language specified
- guides/deployment/shared-db.md:259 Fenced code blocks should have a language specified
- guides/deployment/shared-db.md:419 Fenced code blocks should have a language specified
- guides/deployment/shared-db.md:427 Fenced code blocks should have a language specified
Spelling Mistakes
- guides/deployment/shared-db.md:42:40 Unknown word "Clound"
- guides/deployment/shared-db.md:60:30 Unknown word "esample"
- guides/deployment/shared-db.md:251:3 Unknown word "Authentification"
- guides/deployment/shared-db.md:291:43 Unknown word "asynchronious"
- guides/deployment/shared-db.md:388:4 Unknown word "authentification"
- guides/deployment/shared-db.md:402:29 Unknown word "earch"
- guides/deployment/shared-db.md:443:23 Unknown word "authentification"
Generally, for each spelling mistake there are 2 ways to fix it:
- Fix the spelling mistake and commit it.
- The word is incorrectly reported as misspelled → put the word on the project-words.txt list, located in the root project directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linting Errors
- guides/deployment/shared-db.md:271 Fenced code blocks should have a language specified
Spelling Mistakes
Generally, for each spelling mistake there are 2 ways to fix it:
- Fix the spelling mistake and commit it.
- The word is incorrectly reported as misspelled → put the word on the project-words.txt list, located in the root project directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling Mistakes
- guides/deployment/shared-db.md:42:257 Unknown word "Addinital"
Generally, for each spelling mistake there are 2 ways to fix it:
- Fix the spelling mistake and commit it.
- The word is incorrectly reported as misspelled → put the word on the project-words.txt list, located in the root project directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling Mistakes
- guides/deployment/late-cut-microservices.md:55:5 Unknown word "Modulith"
Generally, for each spelling mistake there are 2 ways to fix it:
- Fix the spelling mistake and commit it.
- The word is incorrectly reported as misspelled → put the word on the project-words.txt list, located in the root project directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling Mistakes
- guides/deployment/late-cut-microservices.md:61:5 Unknown word "Modulith"
Generally, for each spelling mistake there are 2 ways to fix it:
- Fix the spelling mistake and commit it.
- The word is incorrectly reported as misspelled → put the word on the project-words.txt list, located in the root project directory.
guides/deployment/with-shared-db.md
Outdated
Add initial database configuration using the command: | ||
|
||
```shell | ||
cds add hana |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-- for production ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it adds in package.json [production]
"requires": {
"[production]": {
"db": "hana"
}
}
but we moved to
"requires": {
"db": true
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then I don't understand, why do we first do cds add hana
and then set it to true
in the step after? Can't we leave out one of the two steps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to set this for each module. The cds add
command only adds the settings to the root folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a short explanation, particularly since it is the first instance of needing to configure each module
status: released | ||
--- | ||
|
||
# Late-Cut Microservices |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm having a hard time getting my head around this guide. It discusses various options, benefits and disadvantages but I'm missing the guidance somehow. Is it needed to have that discussion first or can we turn it around (as usual in capire) and have the guidance with explanation first. And then we can show the other relevant aspects and discuss them in a addendum?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to create a proposal in my last commit. Basically I switched the order of sections and I moved the Modulith and Microservices section under the first section in the appendix. There, now all concepts are explained and then the more specific aspects are discussed in the following sections. It's still pretty raw, so please let me know what you think about that direction and then we can polish and refine it accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linting Errors
- guides/deployment/with-shared-db.md:67 Fenced code blocks should have a language specified
No description provided.