Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify clip behavior when arguments have different data types #896

Merged
merged 7 commits into from
Feb 17, 2025

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Feb 6, 2025

This PR

@kgryte kgryte added API change Changes to existing functions or objects in the API. topic: Type Promotion Type promotion. labels Feb 6, 2025
@kgryte kgryte added this to the v2024 milestone Feb 6, 2025
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kgryte. Looks good overall, one minor comment about phrasing how Python scalars are handled.

@kgryte kgryte merged commit 0a425d1 into data-apis:main Feb 17, 2025
3 checks passed
@kgryte kgryte deleted the fix/clip-type-promotion branch February 17, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API change Changes to existing functions or objects in the API. topic: Type Promotion Type promotion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants