This repository was archived by the owner on Apr 20, 2023. It is now read-only.
add checks for mysql version, change alter user syntax if it's 8 or g… #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add checks for mysql version, changes
alter user
syntax in case it's 8 or greater. fixes mysql parameter regex in schema.json.Background
the current version of the plugin will break with mysql 8 or mariadb.
it also doesn't accept valid mysql parameter names and values.
Problem
alter user
command used when creating a staging database or vdb is different on MySQL 8.mysqld --version
and it's MariaDBSolution
The MySQL version needs to be checked so the
alter user
command is built properly and the plugin doesn't break completely if it's version 8.The repository parsing needs to check for MySQL or MariaDB so it won't break if it's MariaDB.
Fixing regex so it accepts dashes on property name and dashes or periods in property value.
Testing Done
Tested on my lab and at a customer who's trying delphix on mysql.
Notes to Reviewers
Customer is not entitled to select connector, but these are easy fixes that will benefit any customer.