feat(go/plugins/googlegenai): add constrained generation #2467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugoaguirre
changed the title
rutujaD1999
approved these changes
Mar 26, 2025
apascal07
reviewed
Mar 26, 2025
hugoaguirre
commented
Mar 27, 2025
| @@ -172,6 +174,8 @@ func TestValidMessage(t *testing.T) { | |||
| outputSchema := &ModelOutputConfig{ | |||
| Format: string(OutputFormatJSON), | |||
| } | |||
| // FIX: validMessage compares response against a given schema, but | |||
There was a problem hiding this comment.
Since validMessage checks if the response message matches the given schema (but no schema is provided), would it make sense to rework this and the next two test cases to not expect an error?
| @@ -531,7 +582,7 @@ func validResponse(ctx context.Context, resp *ModelResponse) (*Message, error) { | |||
| // validMessage will validate the message against the expected schema. | |||
| // It will return an error if it does not match, otherwise it will return a message with JSON content and type. | |||
| func validMessage(m *Message, output *ModelOutputConfig) (*Message, error) { | |||
| if output != nil && output.Format == string(OutputFormatJSON) { | |||
| if output != nil && output.Format == string(OutputFormatJSON) && output.Constrained { | |||
There was a problem hiding this comment.
I wanted to check if this condition makes sense at this place. From what I understand, we don't require to validate the response message if no output schema is provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (if applicable):