This repository was archived by the owner on Sep 29, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I currently have the need to read the metadata of an input file, as supplied by ffprobe, e.g. to transcode to different output sizes, depending on the input size of a file.
As this is currently not possible with this library, I tried to implement the changes necessary for that.
The changes include
Metadata
,Format
,Streams
,Tags
andDisposition
, that contain all the necessary gettersMetadata
type definitions in package ffmpeg into their own file, together with implementations of the necessary gettersTranscoder.getMetadata()
and making it available inside theTranscoder
interfaceI've tested reading the metadata with the following code snippet, that demonstrates the changes capabilities:
This PR should not break any existing behaviour. If there are any problems with it, I'll be happy to fix them.