This repository was archived by the owner on Sep 29, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 73
Added GitNbChannel function that return number of channels #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xfrr
reviewed
Jan 25, 2021
"os" | ||
"os/exec" | ||
"regexp" | ||
"strconv" | ||
"strings" | ||
|
||
"github.com/floostack/transcoder" | ||
"github.com/floostack/transcoder/utils" | ||
"github.com/sashker/transcoder" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace by github.com/floostack/transcoder
xfrr
reviewed
Jan 25, 2021
"github.com/floostack/transcoder" | ||
"github.com/floostack/transcoder/utils" | ||
"github.com/sashker/transcoder" | ||
"github.com/sashker/transcoder/utils" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace by github.com/floostack/transcoder
xfrr
suggested changes
Jan 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace imports by github.com/floostack/transcoder
Sorry, by accident I committed changes that belong to my repo, and despite changes of paths they also might break important things like the progress function. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if it was intentional to leave out the number of channels of a stream but for me, this info is required, so I added it.
Tested with the replacement of the module in my go.mod file.