Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump clickhouse-go to v2 #942

Open
magurotuna opened this issue Jun 16, 2023 · 2 comments · May be fixed by #1245
Open

Bump clickhouse-go to v2 #942

magurotuna opened this issue Jun 16, 2023 · 2 comments · May be fixed by #1245

Comments

@magurotuna
Copy link

Is your feature request related to a problem? Please describe.

Currently clickhouse-go v1.4.3 is used as a backing client to connect to ClickHouse, although v1 is in maintenance mode and we are encouraged to switch to v2.

migrate/go.mod

Line 7 in 691bc77

github.com/ClickHouse/clickhouse-go v1.4.3

Describe the solution you'd like

Bump the version of clickhouse-go to v2

Describe alternatives you've considered
N/A

Additional context

What would be concerning about updating to v2 is that it has a few breaking changes that will likely affect the users of golang-migrate as well. For example, connection_open_strategy was set to random in v1, whereas in_order in v2. In my opinion it doesn't matter much for us as the users of golang-migrate, though.
@kluevandrew
Copy link

Any news?

@ribtoks
Copy link

ribtoks commented Aug 28, 2024

I'm hitting a problem where latest migrate binary simply does not work with ClickHouse 23.8.9. However, same code, but supplied with clickhouse-go-v2-created instance of sql.DB and passed as argument to .WithInstance() is working. So updating clickhouse-go to v2 would really help!

@kokizzu kokizzu linked a pull request Mar 11, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update to clickhouse-go/v2 kokizzu/migrate
3 participants
@ribtoks @kluevandrew @magurotuna