-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
session_notes_cleaner is stable enough to become an automated commit action #10
Open
MichaelRWolf
wants to merge
51
commits into
main
Choose a base branch
from
cleanup-part-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- test_contains_inactive_coauthors(self): - def test_delete_inactive_coauthors(self):
This reverts commit 07c9fe3.
. t Update helper function 'doit' with new project structure
…tch various "(in)active co-author" headers
! t ChatGPT generated tests. verify() uses MultiReporter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we renamed the template last session.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChatGPT output
Based on your refinement requests, I'll provide a more detailed analysis of the changes in the diff output, focusing on the specific aspects you've highlighted.
Detailed Analysis:
Restructuring and Code Organization:
src/session_notes_cleanup
tests
src/session_notes_cleanup
: Now containssession_notes_cleaner.py
,doit
, and related files.tests
: Contains new test files forsession_notes_cleaner.py
.Introduction of Test Suite:
unittest
Framework:test_initialization
test_import_approvalTests
test_sample_file_has_no_trailing_whitespace
test_contains_active_coauthors
test_contains_inactive_coauthors
test_delete_inactive_coauthors
test_normalize_coauthor_heading
test_remove_coauthor_headings
test_add_coauthor_heading_before_co_authored_by_list
test_get_date_from_filename
test_cleanup_contents
approvaltests
Framework:test_delete_inactive_coauthors
test_normalize_coauthor_heading
test_remove_coauthor_headings
test_add_coauthor_heading_before_co_authored_by_list
test_cleanup_contents
Details of
doit
Script:doit
script has been modified and relocated tosrc/session_notes_cleanup
.session_notes_cleaner.py
script with each filename.doit
script appears to be a utility script to automate the cleaning of session notes using thesession_notes_cleaner.py
script.Functionality and Interface Changes:
session_notes_cleaner.py
has been introduced or significantly modified with functions likecontains_inactive_coauthors
,delete_inactive_coauthors
, etc.ApprovalTests Output Files:
TestSessionNotesCleaner.test_import_approvalTests.approved.txt
TestSessionNotesCleaner.test_strip_trailing_whitespace.approved.txt
Git and Project Configuration Updates:
.gitignore
files have been updated, indicating changes in project configuration and version control setup..idea
configuration files suggests updates to accommodate IDE-specific settings.This detailed analysis shows a focused effort on enhancing the script for cleaning session notes, introducing comprehensive testing, and reorganizing the project structure for better maintainability and collaboration. The changes in testing and script functionalities align with making the tool more reliable and user-friendly for group use.