Skip to content

updates the tx-poller to stream transactions #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

updates the tx-poller to stream transactions #60

wants to merge 3 commits into from

Conversation

dylanlott
Copy link
Contributor

@dylanlott dylanlott commented Mar 17, 2025 •
edited
Loading

  • shifts the tx-poller to a more actor oriented approach by streaming transactions out of the cache.
  • transaction deduplication and validation is intended to be carried out by the simulator.

Closes ENG-792

@dylanlott Graphite App
Copy link
Contributor Author

dylanlott commented Mar 17, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Mar 17, 2025
Closed
Closed
Closed
@dylanlott dylanlott marked this pull request as ready for review March 17, 2025 01:19
@dylanlott dylanlott self-assigned this Mar 17, 2025
prestwich
prestwich requested changes Mar 17, 2025
View reviewed changes
prestwich
prestwich reviewed Mar 17, 2025
View reviewed changes
prestwich
prestwich reviewed Mar 17, 2025
View reviewed changes
@dylanlott dylanlott mentioned this pull request Mar 17, 2025
Closed
prestwich
prestwich reviewed Mar 17, 2025
View reviewed changes
@dylanlott dylanlott force-pushed the 03-07-updates_the_tx-poller_to_stream_transactions branch from 8b1ec06 to aaeb7c6 Compare March 17, 2025 18:48
prestwich
prestwich reviewed Mar 19, 2025
View reviewed changes
@dylanlott dylanlott force-pushed the 03-07-updates_the_tx-poller_to_stream_transactions branch from aaeb7c6 to aff2cdf Compare March 19, 2025 15:59
@dylanlott dylanlott force-pushed the 03-07-updates_the_tx-poller_to_stream_transactions branch from aff2cdf to 5069931 Compare March 27, 2025 20:46
prestwich
prestwich reviewed Mar 29, 2025
View reviewed changes
dylanlott added 2 commits April 3, 2025 09:45
@dylanlott
updates the tx-poller to stream transactions
ef6b734 
- shifts the tx-poller to a more actor oriented approach by streaming transactions out of the cache.
- transaction deduplication and validation is intended to be carried out by the simulator.
@dylanlott
refactors
1ad6e14 
- improves poll interval handling
- removes arcs
- updates comments
- adds file level comment
@dylanlott dylanlott force-pushed the 03-07-updates_the_tx-poller_to_stream_transactions branch from 5069931 to 1ad6e14 Compare April 3, 2025 19:06
@prestwich prestwich mentioned this pull request Apr 7, 2025
Merged
@prestwich
Copy link
Member

is it intentional that this doesn't change the way the builder consumers the poller? no poller is spawned, the builder owns one and uses the async method to poll itself rather than letting a task poll

@prestwich
Fix: various updates to the tx poller (#67)
b5a5cf4 
* fix: break loop on closure and improve tracing

* refactor: break out the task future
@dylanlott
Copy link
Contributor Author

dylanlott commented Apr 8, 2025 •
edited
Loading

@prestwich that is intended to be updated in a later PR in this stack (see #64 for the pre-revm version approach), and is intended to be tested and merged as a stack, just logically sorted them like this when making the updates. A PR with the wire up is coming once I can get an AlloyDB to play nice with the SimulatorFactory.

anna-carroll
anna-carroll reviewed Apr 10, 2025
View reviewed changes
src/tasks/tx_poller.rs
@@ -1,39 +1,94 @@
//! Transaction service responsible for fetching and sending trasnsactions to the simulator.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: typo: transactions

@dylanlott dylanlott closed this Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestwich prestwich

@anna-carroll anna-carroll

@Evalir Evalir

Assignees

@dylanlott dylanlott

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dylanlott @prestwich @anna-carroll