[rush] Add ChainedCredential to AzureAuthenticationBase to handle auth failover and add support for developer tools credentials
#5169
+140
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmiddha
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
rush-plugins/rush-azure-storage-build-cache-plugin/src/AzureAuthenticationBase.ts
Show resolved
Hide resolved
iclanton
requested changes
Mar 27, 2025
common/changes/@microsoft/rush/bmiddha-chained-authentication_2025-03-21-17-39.json
Outdated
Show resolved
Hide resolved
rush-plugins/rush-azure-storage-build-cache-plugin/src/AzureAuthenticationBase.ts
Show resolved
Hide resolved
rush-plugins/rush-azure-storage-build-cache-plugin/src/ChainedCredential.ts
Outdated
Show resolved
Hide resolved
bmiddha
changed the title
ChainedTokenCredential and add support for developer tools credentials
dmichon-msft
approved these changes
Mar 27, 2025
common/reviews/api/rush-azure-storage-build-cache-plugin.api.md
Outdated
Show resolved
Hide resolved
bmiddha
changed the title
ChainedTokenCredential and add support for developer tools credentialsChainedCredential to AzureAuthenticationBase to handle auth failover and add support for developer tools credentials
bmiddha
commented
Mar 28, 2025
| @@ -35,7 +35,9 @@ export abstract class AzureAuthenticationBase { | |||
| // (undocumented) | |||
| deleteCachedCredentialsAsync(terminal: ITerminal): Promise<void>; | |||
| // (undocumented) | |||
| protected readonly _failoverOrder: Record<LoginFlowType, LoginFlowType | undefined>; | |||
| protected readonly _failoverOrder: { | |||
There was a problem hiding this comment.
updated types here to allow for a subset of LoginFlowType keys to be defined in the Record.
else, bumping rush version would break type checks if only some of the LoginFlowTypes were defined in the record.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement credential failover with
ChainedTokenCredentialfrom@azure/identity.Add support for
VisualStudioCodeCredential,AzureCliCredential,AzureDeveloperCliCredential, andAzurePowerShellCredential. These can help reduce or eliminate the interactive browser popups or device code prompts, which can be annoying.Details
Implement credential failover with
ChainedTokenCredentialfrom@azure/identityNew default credential failover order:
AdoCodespacesAuthCredentialVisualStudioCodeCredentialAzureCliCredentialAzureDeveloperCliCredentialAzurePowerShellCredentialInteractiveBrowserCredentialDeviceCodeCredentialAdd support for new login flows
VisualStudioCodeCredential,AzureCliCredential,AzureDeveloperCliCredential,AzurePowerShellCredential.Updated
AdoCodespacesAuthCredentialto throwCredentialUnavailableErrorto play nicely with the chaining.How it was tested
Manually tested in a repo that uses Azure backed build cache.
Impacted documentation