Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSHARP-5478: Support $rankFusion stage #1636

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

adelinowona
Copy link
Contributor

No description provided.

@adelinowona adelinowona requested a review from a team as a code owner March 18, 2025 00:33
@adelinowona adelinowona requested review from JamesKovacs, rstam and BorisDog and removed request for a team and JamesKovacs March 18, 2025 00:33
@adelinowona adelinowona requested review from rstam and BorisDog March 25, 2025 23:20
Copy link
Contributor

@BorisDog BorisDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, partial review.

Copy link
Contributor

@rstam rstam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for a few minor things it looks good.

@adelinowona adelinowona requested review from rstam and BorisDog March 26, 2025 18:12
@adelinowona adelinowona requested a review from BorisDog March 26, 2025 19:17
@@ -1430,6 +1430,111 @@ public static PipelineStageDefinition<TInput, SearchMetaResult> SearchMeta<TInpu

return stage;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My diff tool is giving me suprious diffs where lines have extra spaces at the end or blank lines have multiple spaces.

You should check your Rider configuration to not write invisible spaces.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This blank line has 8 spaces at the end of it.

Copy link
Contributor

@BorisDog BorisDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adelinowona adelinowona requested a review from rstam March 26, 2025 20:43
Copy link
Contributor

@rstam rstam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extra spaces aren't really a big deal but they show up as diffs in my diff tool.

Might be good to figure out where they are coming from?

@@ -1430,6 +1430,111 @@ public static PipelineStageDefinition<TInput, SearchMetaResult> SearchMeta<TInpu

return stage;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This blank line has 8 spaces at the end of it.

Copy link
Contributor

@rstam rstam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants