Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hidden prefixes #46

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lynxplay
Copy link
Contributor

@lynxplay lynxplay commented Jan 16, 2025

JSTs ignored prefixes are still pushed into the output file sink, which
is not needed when the input and output sources are the same.
The commit adds a stronger version of ignored prefixes, "hidden"
prefixes, which are not processed or pushed to the output sink.

This mainly aims to prevent potential write permission issues on
read-only files during in-place transformation.

Requires: #45

@neoforged-pr-publishing
Copy link

  • Publish PR to GitHub Packages

@Matyrobbrt Matyrobbrt added the enhancement New feature or request label Jan 16, 2025
@neoforged-automation neoforged-automation bot added the needs rebase This Pull Request needs to be rebased before being merged label Feb 16, 2025
@neoforged-automation
Copy link

@lynxplay, this pull request has conflicts, please resolve them for this PR to move forward.

JSTs ignored prefixes are still pushed into the output file sink, which
is not needed when the input and output sources are the same.
The commit adds a stronger version of ignored prefixes, "hidden"
prefixes, which are not processed or pushed to the output sink.

This mainly aims to prevent potential write permission issues on
read-only files during in-place transformation.
@lynxplay lynxplay force-pushed the feature/hidden-prefixes branch from 542f5d5 to 8492caa Compare February 19, 2025 23:57
@neoforged-automation neoforged-automation bot removed the needs rebase This Pull Request needs to be rebased before being merged label Feb 19, 2025
@lynxplay
Copy link
Contributor Author

Rebased 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants