Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because reasoning models a la
o1-mini
don't return all generated tokens the variablemax_tokens
was renamed in the official API tomax_completion_tokens
.max_tokens
is consifered deprecated for chat models but remains supported in older models and is the only supported option for (non-chat) completion API.When using reasoning models set
temperature: None, top_p: None
. The API supports only those values (and temp=1.0 which is equivalent)This PR:
max_tokens
->max_completion_tokens
in ChatBody to support reasoning modelsThis PR is not:
max_tokens
->max_completion_tokens
in every existing use