-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update examples that use createCamera() to explicitly call setCamera() #7607
base: dev-2.0
Are you sure you want to change the base?
Update examples that use createCamera() to explicitly call setCamera() #7607
Conversation
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
did my PR didnt solve the issue? The extra lines that were useless at the bottom, i tried to revert those changes but it keeps coming when i staged the files, may its the formatter of my ide, tell me if it will make any issue , i'll remove those unnecessay changes. |
I correct the unwanted changes, sorry for inconvenience |
Hi @webermayank! Thanks for working on this. I'm adding it to a list of documentation changes that need to be reviewed. We should be able to review and merge this by the end of the month. In the meantime, in case you'd like to continue helping out, I'll outline some additional steps you can take.
Each link can start out with "[need to check page]." Once all the pages are tagged with either "[no change needed]" or "[change reviewed]", we should be able to merge this PR. If you want to do this work (except for the reviewing), just let us know, and at least one of us (@davepagurek, @perminder-17, @holomorfo, or myself) will do a review, so we can merge this. If you don't have time to work on this by the end of next week, we'll help out. Also, @davepagurek: I could look into this more, but since you're already familiar with the changes, I thought I'd ask you a couple things first.
|
@GregStanton, Okay i'll do it, i'll mention all the links related to the |
Thanks so much @webermayank! |
#7602 fix
updated the documentation to call
setCamera()
in case it hadn't been called, in the examples which usescreateCamera()
.List of links with potential changes
p5.Camera/camera
p5.Camera/centerX
p5.Camera/centerY
p5.Camera/centerZ
p5.Camera/eyeX
p5.Camera/eyeY
p5.Camera/eyeZ
p5.Camera/frustum
p5.Camera/lookAt
p5.Camera/move
p5.Camera/ortho
p5.Camera/pan
p5.Camera/perspective
p5.Camera/roll
p5.Camera/set
p5.Camera/setPosition
p5.Camera/slerp
p5.Camera/tilt
p5.Camera/upX
p5.Camera/upY
p5.Camera/upZ
p5/camera
p5/createCamera
p5/linePerspective
p5/ortho
p5/p5.Camera
p5/perspective
p5/setCamera