Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Github Action workflow for updating DW Components Release matrix info to confluence #671

Merged
merged 2 commits into from
Mar 20, 2025
Merged

Add Github Action workflow for updating DW Components Release matrix info to confluence #671

merged 2 commits into from
Mar 20, 2025

Conversation

Srihari1192
Copy link
Contributor

@Srihari1192 Srihari1192 commented Mar 10, 2025 •
edited
Loading

closes https://issues.redhat.com/browse/RHOAIENG-16512

  • Added workflow for adding distributed workloads release matrix info to confluence DW Release details page
  • Validated workflow to handle , if Release versions is upgrading for existing RHOAI release version table to update the new release version details

Issue link

What changes have been made

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@Srihari1192
Copy link
Contributor Author

@sutaakar @ChristianZaccaria @Bobbins228 As GH actions has restricted to 10 parameters , is there any inputs we can hardcode and skip here

@Srihari1192 Srihari1192 force-pushed the RHOAIENG-16512 branch 2 times, most recently from 1744929 to 212632b Compare March 11, 2025 06:09
@Srihari1192
Copy link
Contributor Author

Tested the changes here https://github.com/Srihari1192/codeflare-operator/actions/runs/13782135756

@Srihari1192 Srihari1192 marked this pull request as ready for review March 11, 2025 06:58
@openshift-ci openshift-ci bot requested a review from tedhtchang March 11, 2025 06:58
sutaakar
sutaakar reviewed Mar 11, 2025
View reviewed changes
Copy link
Contributor

@sutaakar sutaakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Personally I don't like this change much as this release workflow is related to upstream release and not downstream, coupling them together is not ideal.

@openshift-ci openshift-ci bot added the lgtm label Mar 11, 2025
ChristianZaccaria
ChristianZaccaria reviewed Mar 11, 2025
View reviewed changes
Copy link
Contributor

@ChristianZaccaria ChristianZaccaria left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

ChristianZaccaria
ChristianZaccaria reviewed Mar 11, 2025
View reviewed changes
Copy link
Contributor

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot removed the lgtm label Mar 11, 2025
@Srihari1192
Copy link
Contributor Author

/lgtm Personally I don't like this change much as this release workflow is related to upstream release and not downstream, coupling them together is not ideal.

Yes, I agree, Karel. However, this approach allows us to track the entire release version matrix in one place for future reference.

@Srihari1192
Copy link
Contributor Author

@ChristianZaccaria @Bobbins228 Could you update the secrets for the variables defined in the workflow? I'll DM you the values.

ChristianZaccaria
ChristianZaccaria approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thanks!

@openshift-ci openshift-ci bot added the lgtm label Mar 20, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChristianZaccaria

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 98fe247 into project-codeflare:main Mar 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sutaakar sutaakar

@Bobbins228 Bobbins228

@ChristianZaccaria ChristianZaccaria

@KPostOffice KPostOffice

@tedhtchang tedhtchang

Assignees

@sutaakar sutaakar

@ChristianZaccaria ChristianZaccaria

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Srihari1192 @sutaakar @Bobbins228 @ChristianZaccaria