Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6176 toast dialog #6376

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

6176 toast dialog #6376

wants to merge 5 commits into from

Conversation

sdvg
Copy link
Member

@sdvg sdvg commented Apr 26, 2024 •
edited by github-actions bot
Loading

☑️ Definition of Done checklist

  • Meaningful title for the release notes
  • Pull request is linked to a problem
  • All changes relate to the problem
  • A11y tests performed successfully or not relevant
  • Manual test performed successfully (by reviewer) or not relevant

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@sdvg sdvg linked an issue Apr 26, 2024 that may be closed by this pull request
🛠️ Todo: Toasts werden vom nativen Dialog Tag verdeckt #6176
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 26, 2024 •
edited
Loading

Netlify Draft Deployment
URL: https://67a0c2f8afa20ee56d25ead8--kolibri-public-ui.netlify.app
Logs: https://app.netlify.com/sites/kolibri-public-ui/deploys/67a0c2f8afa20ee56d25ead8

@sdvg sdvg removed a link to an issue Apr 29, 2024
🛠️ Todo: Toasts werden vom nativen Dialog Tag verdeckt #6176
Closed
@sdvg sdvg closed this Apr 29, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2024
@sdvg sdvg mentioned this pull request Apr 29, 2024
Open
@deleonio deleonio deleted the 6176-toast-dialog branch May 14, 2024 02:55
@deleonio deleonio linked an issue Jul 26, 2024 that may be closed by this pull request
🐞 Bug: toast: Konzept für Tastaturbedienung fehlt #5808
Open
@public-ui public-ui unlocked this conversation Feb 3, 2025
@sdvg sdvg restored the 6176-toast-dialog branch February 3, 2025 12:45
@sdvg sdvg reopened this Feb 3, 2025
sdvg added 3 commits February 3, 2025 13:46
@sdvg
(#6176) test changes
8fb728e
@sdvg
Merge branch 'develop' of github.com:public-ui/kolibri into 6176-toas…
57b268d 
…t-dialog

* 'develop' of github.com:public-ui/kolibri: (1915 commits)
  Fix concurrency group syntax in dod-checker workflow
  Remove auto file generator workflow
  remove some prepack scripts
  Update all snapshots$ $ Refs: #7310
  Fix duplicate import of 'h' in shadow.tsx component
  Fix formRef initialization to handle null value in FormErrorList component
  Enhance error list functionality: improve scrolling and focus behavior for error links
  Enhance error list rendering: add smooth scroll and focus behavior for alert component
  Update all snapshots$ $ Refs: #6645
  update kolibri deps and lock
  Update all snapshots$ $ Refs: #7178
  Extend input fields aria-described property to all types of messages, not just errors
  Unify JSDoc property descriptions
  Fix table double layers and hyphens
  Fix Drawer controlled mode: Allow to open with an initial _open property
  Update all snapshots$ $ Refs: #7178
  KolInputRange: Fix width calculation for number input
  Update all snapshots$ $ Refs: #6645
  Fix icon line-height for edge cases
  Increase contrast for card box-shadow
  ...
@sdvg
Revert changes
a5bcb31 
Refs: #6176
@deleonio deleonio added the v3 Here are issues that need to be resolved for version 3. label Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v3 Here are issues that need to be resolved for version 3.
Projects
KoliBri Board
Status: 🏗 In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 Bug: toast: Konzept für Tastaturbedienung fehlt
2 participants
@sdvg @deleonio