bugfixes for windows spawn

Author: q-nick

package-lock.json

@@ -1,5 +1,4 @@
-import { spawn } from 'child_process';
-
+import { spawn } from '../utils/simple-cross-spawn';
 import { ZERO } from '../utils/utils';
 
 export const executeCommand = (
@@ -18,7 +17,6 @@ export const executeCommand = (
       const spawned = spawn(command, commandArguments, {
         cwd,
         detached: false,
-        shell: process.platform === 'win32',
       });
 
       // wait for stdout, stderr
@@ -34,9 +32,6 @@ export const executeCommand = (
 
       // wait for finish and resolve
       spawned.on('close', (exitStatus: number) => {
-        if (!process.env['NODE_TEST']) {
-          // console.log(exitStatus);
-        }
         if (exitStatus === ZERO) {
           resolve({
             stdout,

server/actions/execute-command.ts

@@ -0,0 +1,30 @@
+import type { ChildProcess, SpawnOptionsWithoutStdio } from 'child_process';
+import { spawn as cpSpawn } from 'child_process';
+
+const metaCharsRegExp = /([ !"%&()*,;<>?[\]^`|])/g;
+
+export const spawn = (
+  command: string,
+  arguments_?: readonly string[],
+  options?: SpawnOptionsWithoutStdio,
+): ChildProcess => {
+  if (process.platform !== 'win32') {
+    return cpSpawn(command, arguments_, options);
+  }
+
+  const shellCommand = [
+    command,
+    ...(arguments_ || []).map((argument) =>
+      `"${argument}"`.replace(metaCharsRegExp, '^$1'),
+    ),
+  ].join(' ');
+
+  return cpSpawn(
+    process.env['comspec'] || 'cmd.exe',
+    ['/d', '/s', '/c', `"${shellCommand}"`],
+    {
+      ...options,
+      windowsVerbatimArguments: true,
+    },
+  );
+};