Allow initializing the build system with the containing toolchain as the developer path #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
requested review from
jakepetroules,
mirza-garibovic,
mhrawdon and
neonichu
as code owners
|
@swift-ci test |
| @@ -169,8 +174,26 @@ public final class Core: Sendable { | |||
|
|
|||
| public let pluginManager: PluginManager | |||
|
|
|||
| public enum DeveloperPath: Sendable, Hashable { | |||
There was a problem hiding this comment.
Yeah, this is great, our previous model definitely didn't well capture the idea that we need to support:
- macOS with Xcode only
- macOS with swift.org toolchain + DCLT
- macOS with swift.org toolchain + Xcode
jakepetroules
requested changes
Apr 7, 2025
owenv
force-pushed
the
owenv/toolchain-dev-path
branch
from
b9c664c to
c65c141
Compare
|
@swift-ci test |
owenv
force-pushed
the
owenv/toolchain-dev-path
branch
from
c65c141 to
238d66d
Compare
|
@swift-ci test |
…the developer path
owenv
force-pushed
the
owenv/toolchain-dev-path
branch
from
238d66d to
5d6337b
Compare
|
@swift-ci test |
neonichu
approved these changes
Apr 8, 2025
jakepetroules
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start distinguishing between the various "kinds" of developer path (Xcode, swift toolchain, fallback). This allows us to distinguish between them in a few key places, such as when we create the stack of default toolchains in settings construction.