Support TBDs in BuildDependencyInfo (rdar://142294767) #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirza-garibovic
requested review from
jakepetroules,
mhrawdon,
neonichu and
owenv
as code owners
|
@swift-ci test |
owenv
approved these changes
Apr 7, 2025
bob-wilson
approved these changes
Apr 7, 2025
mhrawdon
approved these changes
Apr 7, 2025
neonichu
approved these changes
Apr 8, 2025
jakepetroules
approved these changes
Apr 8, 2025
|
https://ci.swift.org/job/pr-swift-build-macos/575/ shows unrelated failures in BuildOperationDescriptionTests.swift and SwiftDriverTests.swift. Going to follow up on those separately. Retrying... @swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles TBDs in the libraries build phase but not in OTHER_LDFLAGS yet, because we don't handle positional arguments at all. We'll need a complete understanding of the ld/driver CLI (and ability to keep it up to date) to support that. Will track that elsewhere.