Skip to content

Use -Xlinker when constructing response files for Swift AST paths #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

owenv
Copy link
Collaborator

@owenv owenv commented Apr 7, 2025

This way we don't need to vary the args based on which compiler is the linker driver

rdar://148630017

@owenv
Copy link
Collaborator Author

owenv commented Apr 7, 2025

@swift-ci test

@mhrawdon
Copy link
Contributor

mhrawdon commented Apr 7, 2025

Yes, -Wl, is especially bad if the path being passed itself contains a comma (the tool often fails to parse the argument). We switched to using -Xlinker for this reason some time ago, and I recommend to everyone that they do the same in their projects. But it's an inertia which is hard to overcome.

@owenv owenv merged commit 086ceee into main Apr 8, 2025
3 checks passed
@owenv owenv deleted the owenv/xlinker branch April 8, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants